fix(deps): correct minium chrono version and MSRV #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2021 09:11
The sentry-core crate uses the chrono::DurationRound trait which was only introduced in chrono 0.4.13. The sentry-types crate is updated just to keep the versions in sync.
The socket2 dependency (pulled in via hyper) uses this.
flub
changed the title
|
Do not be confused by the unfinished CI checks, everything works if we're ok with bumping the MSRV to 1.46 (I couldn't find this in any documentation so didn't update it). The branch protection needs to be updated if we approve this. So this is as ready for review as it gets. |
flub
changed the title
Swatinem
approved these changes
Apr 9, 2021
|
#316 would require a MSRV bump as well since actix bumped it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sentry-core crate uses the chrono::DurationRound trait which was
only introduced in chrono 0.4.13. The sentry-types crate is updated
just to keep the versions in sync.