Skip to content

fix: Don't attach Android Threads #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

fix: Don't attach Android Threads #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions android/src/main/java/io/sentry/RNSentryModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ public Map<String, Object> getConstants() {
public void startWithOptions(final ReadableMap rnOptions, Promise promise) {
SentryAndroid.init(this.getReactApplicationContext(), options -> {
if (rnOptions.hasKey("dsn") && rnOptions.getString("dsn") != null) {
options.setDsn(rnOptions.getString("dsn"));
String dsn = rnOptions.getString("dsn");
logger.info(String.format("Starting with DSN: '%s'", dsn));
options.setDsn(dsn);
} else {
// SentryAndroid needs an empty string fallback for the dsn.
options.setDsn("");
Expand All @@ -82,6 +84,10 @@ public void startWithOptions(final ReadableMap rnOptions, Promise promise) {
options.setDist(rnOptions.getString("dist"));
}

// JS use top level stacktraces and android attaches Threads which hides them so by default we hide.
boolean attachThreads = rnOptions.hasKey("attachThreads") && rnOptions.getBoolean("attachThreads");
options.setAttachThreads(attachThreads);

options.setBeforeSend((event, hint) -> {
// React native internally throws a JavascriptException
// Since we catch it before that, we don't want to send this one
Expand Down Expand Up @@ -112,10 +118,6 @@ public void startWithOptions(final ReadableMap rnOptions, Promise promise) {
sentryOptions = options;
});

if (rnOptions.hasKey("dsn")) {
logger.info(String.format("startWithDsnString '%s'", rnOptions.getString("dsn")));
}

promise.resolve(true);
}

Expand Down