fix: Don't attach Android Threads #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Unless explicitly passed in via configuration, attachThreads will be
false.💡 Motivation and Context
JS sends event.stacktrace (see getsentry/sentry-javascript#2605 and
sentry-androidattaches event.threads and the UI picks the threads instead. But that means the stacktrace unrelated to any thread doesn't render, and the Java threads are irrelevant (in fact they don't include any frame). Lastly threads don't seem to be useful in this context💚 How did you test it?
Used the sample app
📝 Checklist
🔮 Next steps