Skip to content

Commit a106cc1

Browse files
authored
fix: Don't attach Android Threads (#866)
1 parent f492713 commit a106cc1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

android/src/main/java/io/sentry/RNSentryModule.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ public Map<String, Object> getConstants() {
6464
public void startWithOptions(final ReadableMap rnOptions, Promise promise) {
6565
SentryAndroid.init(this.getReactApplicationContext(), options -> {
6666
if (rnOptions.hasKey("dsn") && rnOptions.getString("dsn") != null) {
67-
options.setDsn(rnOptions.getString("dsn"));
67+
String dsn = rnOptions.getString("dsn");
68+
logger.info(String.format("Starting with DSN: '%s'", dsn));
69+
options.setDsn(dsn);
6870
} else {
6971
// SentryAndroid needs an empty string fallback for the dsn.
7072
options.setDsn("");
@@ -82,6 +84,10 @@ public void startWithOptions(final ReadableMap rnOptions, Promise promise) {
8284
options.setDist(rnOptions.getString("dist"));
8385
}
8486

87+
// JS use top level stacktraces and android attaches Threads which hides them so by default we hide.
88+
boolean attachThreads = rnOptions.hasKey("attachThreads") && rnOptions.getBoolean("attachThreads");
89+
options.setAttachThreads(attachThreads);
90+
8591
options.setBeforeSend((event, hint) -> {
8692
// React native internally throws a JavascriptException
8793
// Since we catch it before that, we don't want to send this one
@@ -112,10 +118,6 @@ public void startWithOptions(final ReadableMap rnOptions, Promise promise) {
112118
sentryOptions = options;
113119
});
114120

115-
if (rnOptions.hasKey("dsn")) {
116-
logger.info(String.format("startWithDsnString '%s'", rnOptions.getString("dsn")));
117-
}
118-
119121
promise.resolve(true);
120122
}
121123

0 commit comments

Comments
 (0)