POC: Support artifact bundles (DebugID) #2900

krystofwoldrich · 2023-03-16T16:28:02Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

How to test

yarn
yarn build
cd sample-new-architecture
yarn
cd sample-new-architecture/android
./gradlew assembleRelease
adb install app/build/outputs/apk/release/app-release.apk

💡 Motivation and Context

Test Source Maps DebugID #2892

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

… kw-source-maps-debug-id

github-actions · 2023-03-16T16:31:02Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Support artifact bundles (DebugID) ([#2900](https://github.com/getsentry/sentry-react-native/pull/2900))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against fba86e6

github-actions · 2023-03-16T16:54:46Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	364.10 ms	370.44 ms	6.34 ms
Size	17.73 MiB	19.76 MiB	2.02 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB

github-actions · 2023-03-16T17:16:55Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1230.61 ms	1232.76 ms	2.15 ms
Size	2.92 MiB	3.40 MiB	495.23 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB

github-actions · 2023-03-16T17:24:44Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	273.63 ms	329.51 ms	55.88 ms
Size	7.15 MiB	8.04 MiB	914.01 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB

github-actions · 2023-03-17T09:26:54Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.88 ms	1232.50 ms	7.62 ms
Size	2.36 MiB	2.84 MiB	490.45 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms

App size

Revision	Plain	With Sentry	Diff
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB

github-actions · 2023-04-08T00:10:25Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

krystofwoldrich · 2023-07-05T10:12:40Z

Closing in favor of Add Debug Ids support for JSC and Hermes bundles #3164

krystofwoldrich and others added 6 commits March 15, 2023 16:00

WIP! Refactor sentry.gradle for source maps injection

cfd96ef

chore: update scripts/update-cli.sh to 2.15.1

888b76b

Merge remote-tracking branch 'origin/deps/scripts/update-cli.sh' into…

3c02e96

… kw-source-maps-debug-id

Add sourcemaps upload to sentry.gradle

0d9c402

Add ambiguous version

42dd3fd

Add unique exceptions

afe5ea7

Add code_file path tmp fix

608f2fc

github-actions bot added the Status: Stale label Apr 8, 2023

krystofwoldrich added Status: Backlog and removed Status: Stale labels Apr 11, 2023

krystofwoldrich added 3 commits April 25, 2023 14:26

Merge remote-tracking branch 'origin/main' into kw-source-maps-debug-id

efbcc84

Fix lint

2b2dff6

WIP! Adjust sentry.gradle based on the new cli behavior

fba86e6

krystofwoldrich mentioned this pull request Jul 5, 2023

Add Debug Ids support for JSC and Hermes bundles #3164

Merged

15 tasks

krystofwoldrich closed this Jul 5, 2023

krystofwoldrich mentioned this pull request Jul 5, 2023

Add support for Source Maps Debug ID in Hermes bundle #2947

Closed

krystofwoldrich deleted the kw-source-maps-debug-id branch October 4, 2023 14:05

Uh oh!

POC: Support artifact bundles (DebugID) #2900

POC: Support artifact bundles (DebugID) #2900

Uh oh!

Conversation

krystofwoldrich commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

How to test

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Instructions and example for changelog

Uh oh!

github-actions bot commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Apr 8, 2023

Uh oh!

krystofwoldrich commented Jul 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

krystofwoldrich commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 17, 2023 •

edited

Loading