Skip to content

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Sep 10, 2021

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Rename the React Navigation V5 instrumentation by removing the V5 prefix as the same instrumentation supports both V5 and V6. We still export the reactNavigationV5Instrumentation for backwards compatibility purposes with a @deprecated tag.

💡 Motivation and Context

Resolves #1756

💚 How did you test it?

Tested on an example app with React Navigation 6.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@jennmueng jennmueng self-assigned this Sep 10, 2021
@jennmueng jennmueng changed the title ref: Remove v5 prefix from react navigation inst. to support v6 ref: Remove v5 prefix from react navigation instrumentation to support v6 Sep 10, 2021
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! We just need a migration guide and equivalent patching on the docs 🙏

thanks!

@jennmueng jennmueng merged commit 320b8a9 into master Sep 13, 2021
@jennmueng jennmueng deleted the jenn/rn-nav-v6 branch September 13, 2021 18:47
@shamilovtim
Copy link

Docs still call out v5 a ton. Might want to change that

@marandaneto
Copy link
Contributor

Docs still call out v5 a ton. Might want to change that

mind sharing the links? I've found only one mention of the v5 name, getsentry/sentry-docs#4255

@shamilovtim
Copy link

https://docs.sentry.io/platforms/react-native/performance/instrumentation/automatic-instrumentation/#react-navigation
Version 5 and above

https://docs.sentry.io/platforms/react-native/performance/instrumentation/automatic-instrumentation/#configuration
ReactNavigationV5Instrumentation

https://docs.sentry.io/platforms/react-native/
Performance Monitoring creates transactions automatically for React Navigation v4 and v5; creates spans automatically for XHR and Fetch

There could be more but those are just the obvious ones I saw that confused me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for React Navigation v6
4 participants