Skip to content

Rename ReactNavigationV5Instrumentation to ReactNavigationInstrumentation #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

marandaneto
Copy link
Contributor

No description provided.

@marandaneto marandaneto requested a review from a team as a code owner October 11, 2021 07:24
@vercel
Copy link

vercel bot commented Oct 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/GWQa3wKrMsKvev3BkqeFyuVg9zYm
✅ Preview: https://sentry-docs-git-fix-react-v5-to-v6v6.sentry.dev

@marandaneto
Copy link
Contributor Author

@jennmueng we probably need an entry in the migration changelog as well? https://docs.sentry.io/platforms/react-native/migration/

found by getsentry/sentry-react-native#1768 (comment)
not sure if there's any other mention of ReactNavigationV5Instrumentation, could not find at least

@jennmueng
Copy link
Member

jennmueng commented Oct 14, 2021

@jennmueng we probably need an entry in the migration changelog as well? https://docs.sentry.io/platforms/react-native/migration/

found by getsentry/sentry-react-native#1768 (comment) not sure if there's any other mention of ReactNavigationV5Instrumentation, could not find at least

This looks good, and this is my approve by comment✅. Yes looks like we would need a migration log as welll, completely forgot about that 😅adding to my immediate TODO.

@marandaneto marandaneto merged commit 5da67cb into master Oct 15, 2021
@marandaneto marandaneto deleted the fix/react-v5-to-v6v6 branch October 15, 2021 06:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants