Skip to content

test(browser-integration): Tweak promises a bit to reduce flakes in replay tests #9477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 7, 2023

...maybe

Based on what we did in #9025

@billyvg billyvg changed the title test(browser-integration): Tweak promises a bit to reduce flakes test(browser-integration): Tweak promises a bit to reduce flakes in replay tests Nov 8, 2023
@billyvg billyvg marked this pull request as ready for review November 8, 2023 15:38
@lforst
Copy link
Contributor

lforst commented Nov 8, 2023

Wouldn't this increase flakyness? Doesn't this pattern make the order of execution even more random?

@billyvg
Copy link
Member Author

billyvg commented Nov 8, 2023

The promises being grouped don't depend on them being executed sequentially, so the order shouldn't matter.

@billyvg billyvg merged commit 636f4d9 into develop Nov 9, 2023
@billyvg billyvg deleted the test-fix-flakey-tests branch November 9, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants