Skip to content

ref(tests): Update replay integration tests to avoid flakes. #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 26, 2023
Merged

ref(tests): Update replay integration tests to avoid flakes. #9025

merged 7 commits into from
Sep 26, 2023

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Sep 14, 2023 •
edited
Loading

Resolves: #8975

Refactored most flaky replay tests to Promise.all pattern to reduce flakiness.

@onurtemizkan onurtemizkan force-pushed the onur/refactor-replay-integration-tests branch 6 times, most recently from 2d93c08 to d225f13 Compare September 20, 2023 16:47
@onurtemizkan onurtemizkan marked this pull request as ready for review September 20, 2023 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.58 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.46 KB (0%)
@sentry/browser - Webpack (gzipped) 22.06 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.28 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.57 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.65 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 222.21 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.57 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.42 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.43 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.61 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.09 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.48 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.04 KB (0%)

@onurtemizkan onurtemizkan marked this pull request as draft September 20, 2023 17:09
@onurtemizkan onurtemizkan force-pushed the onur/refactor-replay-integration-tests branch 2 times, most recently from 48079eb to ecc6429 Compare September 20, 2023 17:25
billyvg
billyvg reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! -- anything else you're waiting on for this?

@onurtemizkan onurtemizkan force-pushed the onur/refactor-replay-integration-tests branch from 506d20c to c2007e5 Compare September 26, 2023 11:32
@onurtemizkan onurtemizkan force-pushed the onur/refactor-replay-integration-tests branch from c2007e5 to d5c0ba3 Compare September 26, 2023 12:45
@onurtemizkan onurtemizkan marked this pull request as ready for review September 26, 2023 13:10
@onurtemizkan
Copy link
Collaborator Author

anything else you're waiting on for this?

@billyvg, this still does not cover all potentially flaky tests. But after including slowClick tests, I think it's ready to go now. We can address later, if we see any other tests with issues.

billyvg
billyvg approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get these merged then, I can check my list of flakes and update them as necessary. Thanks!

@billyvg billyvg mentioned this pull request Sep 26, 2023
Closed
@billyvg billyvg merged commit 5a9c916 into develop Sep 26, 2023
@billyvg billyvg deleted the onur/refactor-replay-integration-tests branch September 26, 2023 16:48
billyvg pushed a commit that referenced this pull request Sep 26, 2023
@onurtemizkan @billyvg
ref(tests): Update replay integration tests to avoid flakes. (#9025)
b7c5571 
Resolves: #8975

Refactored most flaky replay tests to `Promise.all` pattern to reduce
flakiness.
c298lee pushed a commit that referenced this pull request Sep 27, 2023
@onurtemizkan @c298lee
ref(tests): Update replay integration tests to avoid flakes. (#9025)
0271c25 
Resolves: #8975

Refactored most flaky replay tests to `Promise.all` pattern to reduce
flakiness.
@billyvg billyvg mentioned this pull request Nov 8, 2023
Merged
billyvg added a commit that referenced this pull request Nov 9, 2023
@billyvg
test(browser-integration): Tweak promises a bit to reduce flakes in r…
636f4d9 
…eplay tests (#9477)

...maybe


Based on what we did in #9025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: [chromium] › suites/replay/requests/test.ts:48:11 › replay recording should contain XHR request span
2 participants
@onurtemizkan @billyvg