feat(node): Remove lru_map dependency
#9300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Oct 18, 2023
| }, | ||
| "devDependencies": { | ||
| "@rollup/plugin-commonjs": "^25.0.5", |
There was a problem hiding this comment.
was this this just there for lru_map?
| public values(): Array<V> { | ||
| const values: V[] = []; | ||
| this._cache.forEach(value => values.push(value)); | ||
| return values; |
There was a problem hiding this comment.
why this over Array.from(this._cache.values())?
There was a problem hiding this comment.
That triggers a lint:
ES6 methods not allowed: valueseslint(@sentry-internal/sdk/no-unsupported-es6-methods)
This method is currently only used by some tests...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9199
This PR:
LRUMapto utilslru_mapMap.prototype.keys()returns an iterator in order of insertion so the oldest entry key iskeys().next().valuelru_mapWe could add
LRUMapto@sentry/nodebut it might be useful elsewhere and it's required in the Electron SDK and it would be better not to add an export to a public API.