Node SDK - Vendor dependencies #9199
Comments
timfish
added
Type: Improvement
Package: node
|
This makes me think we can just remove tslib 🤔 |
|
I looked at vendoring the last dependency |
|
I think we just forgot about updating it - let's update it first and then remove the dep. |
|
I've created a PR to vendor the latest version (v7) of This would explain why it hasn't been updated in the Node SDK! Probably best to merge this change with the next major rather than spend the time trying to vendor the older (non-typescript) version. |
Closes #9199 This PR vendors the `https-proxy-agent` code and in the process updates to v7.0.0. `https-proxy-agent` is our last remaining cjs-only dependency so this is required for #10046. This removes the following dependencies: - `[email protected]` - `[email protected]` - `[email protected]` - `[email protected]` The vendored code has been modified to use the Sentry logger rather than `debug`. Initially, rather than modify the vendored code substantially just to pass our tight lint rules, I've disabled a few of the less important lints that would make it particularly tricky to pull in upstream bug fixes: ```ts /* eslint-disable @typescript-eslint/explicit-member-accessibility */ /* eslint-disable @typescript-eslint/member-ordering */ /* eslint-disable jsdoc/require-jsdoc */ ``` ## Min supported Node version `https-proxy-agent` has a `@types/[email protected]` dev dependency but apart from adding an import for `URL`, I can't find anything that would stop it working on older versions of node and there is nothing in the changelogs that would suggest the min supported version has changed. --------- Co-authored-by: Abhijeet Prasad <[email protected]>
Problem Statement
@sentry/nodehas a few non-Sentry dependencies:modulesdebugdependency has side-effects that readprocess.envwhich means we can't load any code from@sentry/nodein runtimes that don't supportprocessSolution Brainstorm
Vendor them!
The text was updated successfully, but these errors were encountered: