Skip to content

feat(replay): Allow to capture replays for electron #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 4, 2023

This adds a check to make sure replay runs on electron.

This may not be bullet proof, but I'd say it should be good enough for us.

Closes #6630

@mydea mydea requested review from billyvg, timfish and Lms24 January 4, 2023 10:57
@mydea mydea self-assigned this Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.8 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.31 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.59 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.88 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.35 KB (0%)
@sentry/browser - Webpack (minified) 66.5 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.37 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.62 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.77 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.21 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.72 KB (+0.11% 🔺)

@timfish
Copy link
Collaborator

timfish commented Jan 4, 2023

It's possible to change the user agent in Electron and I've seen this used to make it appear like regular Chrome since things like Google login block "webviews". I don't know how common it is to do that or whether it will pose an issue.

I came up with this.

@mydea
Copy link
Member Author

mydea commented Jan 4, 2023

It's possible to change the user agent in Electron and I've seen this used to make it appear like regular Chrome since things like Google login block "webviews". I don't know how common it is to do that or whether it will pose an issue.

I came up with this.

Ah, sorry, missed this - closing this in favor of that PR!

@mydea mydea closed this Jan 4, 2023
@mydea mydea deleted the fn/allow-replay-electron branch January 16, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to capture replays for Electron when node integration is enabled
2 participants