Allow to capture replays for Electron when node integration is enabled

[timfish]

Which package are you using?

@sentry/electron

SDK Version

master

Steps to Reproduce

Ref: getsentry/sentry-electron#606 (comment)

This code:

sentry-javascript/packages/replay/src/integration.ts

Lines 138 to 141 in 36488ec

	setupOnce(): void {
	if (!isBrowser()) {
	return;
	}

Means that Replay cannot be used in Electron renderers when nodeIntegration is enabled as process is defined. This has not been the default config for a couple of years and it's not recommended but it's still used a lot in real world applications.

Expected Result

Replay should work in Electron renderers

Actual Result

Doesn't work

Is this check required? What is it trying to protect against?

[mydea]

Basically, the idea of this check is to ensure we do not run replay when running in non-browser environments, e.g. node (especially e.g. Next.js or similar envs). As replay relies on a lot of DOM etc. stuff.

I would be a bit hesistant to change this as it could lead to a bunch of other errors. We could also just check for existence of window, which may be good enough, but may also let some other stuff slip through I guess.

Options I see, cc @billyvg & @Lms24:

1. Change nothing, Electron apps with process will not work with Replay
2. Relax the check to only check for existence of window
3. Allow to overwrite this in an experiment, e.g. _experiments.isBrowser = true or similar

[Lms24]

I agree that we should be careful with making changes here.

@timfish Is there away we can add a check for electron specifically?

So that in the end we could do something along the lines of

if (!isBrowser() && !isElectronWithProcess()) return