Skip to content

ref(build): Switch from using rollup-plugin-re to rollup-plugin-cleanup #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

lobsterkatie
Copy link
Member

This is based on #5799, but preserves comments in out built output and cleans up a few comments in the plugin file.

@lforst
Copy link
Contributor

lforst commented Sep 27, 2022

As far as I can remember the outcome of the discussion was that we want to remove as much complexity from the build-process as possible. Adding the cleanup plugin is adding complexity again. To me, the output isn't ugly enough to justify adding a dependency in one of the most fragile steps.

@lobsterkatie
Copy link
Member Author

As far as I can remember the outcome of the discussion was that we want to remove as much complexity from the build-process as possible. Adding the cleanup plugin is adding complexity again. To me, the output isn't ugly enough to justify adding a dependency in one of the most fragile steps.

The fact that sucrase is determined to not change line numbers between original and built files means that the files do come out looking kind of funky. And honestly, using this plugin to fix line endings and delete blank lines is one of the least complex parts of the process, either to understand as a reader or to introduce potential for bugs. I think it's worth it.

@lobsterkatie lobsterkatie merged commit 12c19d0 into master Sep 27, 2022
@lobsterkatie lobsterkatie deleted the kmclb-remove-build-cleanup-regexes branch September 27, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants