ref(build): Remove all comments in generated output #5799
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #5783 and the contained discussion.
Quoted from that PR:
The existing regex, when presented with code like this:
matches everything between the initial
/*
on the first line and the final*/
on the second-to-last line, and the plugin thus removes all but the last line of the file. This fixes the regex so that only the comments are removed.In order to avoid similar bugs, and since comment-removal is not as simple as applying a regex, we should outsource comment deletion to a dedicated library - in this case
rollup-plugin-cleanup
. I decided to remove all comments instead of only multi-line ones because the upside of only having certain ones is unclear to me.Important comments like tree-shaking hints or source map comments are still intact.