-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(vue): accounts for undefined options when formatting component name #5254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AbhiPrasad
merged 2 commits into
getsentry:master
from
Arinono:fix/5204/vue-options-undefined
Jun 14, 2022
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,120 @@ | ||
import { formatComponentName } from '../src/components'; | ||
|
||
it('properly format component names', () => { | ||
const vm: any = { | ||
$options: {}, | ||
}; | ||
vm.$root = vm; | ||
expect(formatComponentName(vm)).toBe('<Root>'); | ||
|
||
vm.$root = null; | ||
vm.$options.name = 'hello-there'; | ||
expect(formatComponentName(vm)).toBe('<HelloThere>'); | ||
|
||
vm.$options.name = null; | ||
vm.$options._componentTag = 'foo-bar-1'; | ||
expect(formatComponentName(vm)).toBe('<FooBar1>'); | ||
|
||
vm.$options._componentTag = null; | ||
vm.$options.__file = '/foo/bar/baz/SomeThing.vue'; | ||
expect(formatComponentName(vm)).toBe(`<SomeThing> at ${vm.$options.__file}`); | ||
expect(formatComponentName(vm, false)).toBe('<SomeThing>'); | ||
|
||
vm.$options.__file = 'C:\\foo\\bar\\baz\\windows_file.vue'; | ||
expect(formatComponentName(vm)).toBe(`<WindowsFile> at ${vm.$options.__file}`); | ||
expect(formatComponentName(vm, false)).toBe('<WindowsFile>'); | ||
describe('formatComponentName', () => { | ||
describe('when the vm is not defined', () => { | ||
it('returns the anonymous component name', () => { | ||
// arrange | ||
const vm = undefined; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm); | ||
|
||
// assert | ||
expect(formattedName).toEqual('<Anonymous>'); | ||
}); | ||
}); | ||
|
||
describe('when the vm is defined', () => { | ||
let vm: any = undefined; | ||
|
||
beforeEach(() => { | ||
vm = {}; | ||
}); | ||
|
||
describe('and when the $options is not defined', () => { | ||
it('returns the anonymous component name', () => { | ||
// arrange | ||
vm.$options = undefined; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm); | ||
|
||
// assert | ||
expect(formattedName).toEqual('<Anonymous>'); | ||
}); | ||
}); | ||
|
||
describe('when the $options is defined', () => { | ||
beforeEach(() => { | ||
vm = { $options: {} }; | ||
}); | ||
|
||
describe('when the vm is the $root', () => { | ||
it('returns the root component name', () => { | ||
// arrange | ||
vm.$root = vm; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm); | ||
|
||
// assert | ||
expect(formattedName).toEqual('<Root>'); | ||
}); | ||
}); | ||
|
||
describe('when the $options have a name', () => { | ||
it('returns the name', () => { | ||
// arrange | ||
vm.$options.name = 'hello-there'; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm); | ||
|
||
// assert | ||
expect(formattedName).toEqual('<HelloThere>'); | ||
}); | ||
}); | ||
|
||
describe('when the options have a _componentTag', () => { | ||
it('returns the _componentTag', () => { | ||
// arrange | ||
vm.$options._componentTag = 'foo-bar-1'; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm); | ||
|
||
// assert | ||
expect(formattedName).toEqual('<FooBar1>'); | ||
}); | ||
}); | ||
|
||
describe('when the options have a __file', () => { | ||
describe('and we do not wish to include the filename', () => { | ||
it.each([ | ||
['unix', '/foo/bar/baz/SomeThing.vue', '<SomeThing>'], | ||
['unix', '/foo/bar/baz/SomeThing.ts', '<Anonymous>'], | ||
['windows', 'C:\\foo\\bar\\baz\\windows_file.vue', '<WindowsFile>'], | ||
['windows', 'C:\\foo\\bar\\baz\\windows_file.ts', '<Anonymous>'], | ||
])('returns the filename (%s)', (_, filePath, expected) => { | ||
// arrange | ||
vm.$options.__file = filePath; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm, false); | ||
|
||
// assert | ||
expect(formattedName).toEqual(expected); | ||
}); | ||
}); | ||
|
||
describe('and we wish to include the filename', () => { | ||
it.each([ | ||
['unix', '/foo/bar/baz/SomeThing.vue', '<SomeThing>'], | ||
['unix', '/foo/bar/baz/SomeThing.ts', '<Anonymous>'], | ||
['windows', 'C:\\foo\\bar\\baz\\windows_file.vue', '<WindowsFile>'], | ||
['windows', 'C:\\foo\\bar\\baz\\windows_file.ts', '<Anonymous>'], | ||
])('returns the filename (%s)', (_, filePath, expected) => { | ||
// arrange | ||
vm.$options.__file = filePath; | ||
|
||
// act | ||
const formattedName = formatComponentName(vm); | ||
|
||
// assert | ||
expect(formattedName).toEqual(`${expected} at ${filePath}`); | ||
}); | ||
}); | ||
}); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main test I added.
Commenting the fix will make this test fail.
The rest is refactor (and the right-side ternary on
name
line 50 which was not covered).