fix(vue): accounts for undefined options when formatting component name #5254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When formatting the component name, options can be undefined. When it is, we return the ANONYMOUS_COMPONENT_NAME early Fixes getsentry#5204
Arinono
force-pushed
the
fix/5204/vue-options-undefined
branch
from
ee0acd6 to
6139907
Compare
Arinono
commented
Jun 13, 2022
Comment on lines
+24
to
+35
| describe('and when the $options is not defined', () => { | ||
| it('returns the anonymous component name', () => { | ||
| // arrange | ||
| vm.$options = undefined; | ||
|
|
||
| // act | ||
| const formattedName = formatComponentName(vm); | ||
|
|
||
| // assert | ||
| expect(formattedName).toEqual('<Anonymous>'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This is the main test I added.
Commenting the fix will make this test fail.
The rest is refactor (and the right-side ternary on name line 50 which was not covered).
AbhiPrasad
approved these changes
Jun 14, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5204
Implementation details
Returns the
ANONYMOUS_COMPONENT_NAMEearly ifvm.$optionsis not defined.Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).