Skip to content

feat(v8/replay): Remove deprecated replay options #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2024
Merged

feat(v8/replay): Remove deprecated replay options #11268

merged 3 commits into from
Mar 26, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 25, 2024 •
edited
Loading

ref #9834
ref #10100

  • Remove deprecated privacy options for replay
  • Add @sentry/replay changes to migration doc
  • Re-add back Replay migration doc

@AbhiPrasad AbhiPrasad requested review from mydea and s1gr1d March 25, 2024 14:52
@AbhiPrasad AbhiPrasad self-assigned this Mar 25, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 25, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.54 KB (added)
@sentry/browser (incl. Tracing, Replay) 71.88 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.69 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.44 KB (added)
@sentry/browser (incl. Tracing) 36.7 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.7 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.44 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (added)
@sentry/browser (incl. sendFeedback) 27.4 KB (added)
@sentry/browser 22.56 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.89 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.72 KB (added)
CDN Bundle (incl. Tracing) 36.29 KB (added)
CDN Bundle 23.92 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.96 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.52 KB (added)
CDN Bundle - uncompressed 70.85 KB (added)
@sentry/react (incl. Tracing, Replay) 71.85 KB (added)
@sentry/react 22.59 KB (added)

mydea
mydea approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @billyvg mind also looking over this?

@AbhiPrasad
feat(v8/replay): Remove deprecated replay options
e9e2b6e 
- Remove deprecated privacy options for replay
- Add @sentry/replay changes to migration doc
- Re-add back Replay migration doc
@AbhiPrasad
fix tests
b5d0b44
@AbhiPrasad
fix test
99098a1
@AbhiPrasad AbhiPrasad force-pushed the abhi-replay-deprecations branch from 0dcc8cf to 99098a1 Compare March 26, 2024 12:57
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 26, 2024 13:12
@AbhiPrasad AbhiPrasad merged commit 7bec613 into develop Mar 26, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-replay-deprecations branch March 26, 2024 13:24
billyvg
billyvg reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/replay): Remove deprecated replay options (getsentry#11268)
e757d1c 
ref getsentry#9834
ref getsentry#10100

- Remove deprecated privacy options for replay
- Add @sentry/replay changes to migration doc
- Re-add back Replay migration doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg left review comments

@mydea mydea mydea approved these changes

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @billyvg @mydea