-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Remove health check transaction filters #10818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
## Removal of Client-Side health check transaction filters | ||
|
||
The SDK no longer filters out health check transactions by default. Instead, they are sent to Sentry but still dropped | ||
by the Sentry backend by default. You can disable dropping them in your Sentry project settings. If you still want to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a note here that they are dropped by default for projects created after X? As I guess that is the case here...? And add a note like "If your project was created before X, you can enable the inbound filter for this at Y"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the server side inbound filter was turned on for all projects 🤔 I checked for projects in Sentry that were created way before we introduced the filter and there it's also turned on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I'm not too sure anymore
- seems like the filter was supposed to be disabled by default first (Inbound Filter for HealthChecks sentry#46731)
- later, we changed it to enabled for new projects (feat(inbound-filters): Turn on some filters for new Javascript projects sentry#62654)
Will keep looking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so even the projects in my private org have the filter turned on and I definitely didn't flip any switches there. I didn't find additional PRs that would have changed the defaults in older project but I asked in slack (#discuss-issues
) to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to the issues team; the health check transaction filter is on by default for all (old and new) projects. So we should be good to go @mydea 👍
This PR removes the
ignoreTransactions
default values which were all patterns trying to identify health check transactions.We remove these because:
Implementation note: Decided to remove the entire defaults array b/c there's no point in keeping around an empty array. Therefore, I also removed the
ignoreTransactionDefaults
option. We can re-add all of this if we ever want to filter out something by default again but for now, I'd argue the bundle size reduction is worth removing this code.