Skip to content

feat(inbound-filters): Turn on some filters for new Javascript projects #62654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

roggenkemper
Copy link
Member

this pr will update how projects are created so that new javascript platform projects have some of the inbound filters turned on by default. browser extension, health check transaction, legacy browser, and web crawler filters will be on by default for these new javascript based projects. it will not impact projects of any other platform, nor will it change the filters for any existing project.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d165ce) 81.30% compared to head (bf8deeb) 81.34%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #62654      +/-   ##
==========================================
+ Coverage   81.30%   81.34%   +0.03%     
==========================================
  Files        5201     5202       +1     
  Lines      230405   230418      +13     
  Branches    39815    39818       +3     
==========================================
+ Hits       187334   187423      +89     
+ Misses      37328    37251      -77     
- Partials     5743     5744       +1     
Files Coverage Δ
src/sentry/api/endpoints/team_projects.py 93.05% <100.00%> (+0.30%) ⬆️
src/sentry/api/helpers/default_inbound_filters.py 100.00% <100.00%> (ø)
...interfaces/breadcrumbs/breadcrumb/data/default.tsx 37.50% <ø> (ø)
...s/interfaces/breadcrumbs/breadcrumb/data/index.tsx 33.33% <ø> (ø)
...interfaces/breadcrumbs/breadcrumb/data/summary.tsx 87.50% <ø> (ø)
static/app/types/breadcrumbs.tsx 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

@roggenkemper roggenkemper marked this pull request as ready for review January 5, 2024 19:23
@roggenkemper roggenkemper requested a review from a team January 8, 2024 17:43
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a longer term plan to enable this for older projects?

@roggenkemper
Copy link
Member Author

Is there a longer term plan to enable this for older projects?

The next milestone is to do this for existing projects, but there is no currently timeline / plan for how we want to do this

@roggenkemper roggenkemper merged commit 57107d8 into master Jan 9, 2024
@roggenkemper roggenkemper deleted the roggenkemper/inboundfiltersdefault branch January 9, 2024 21:01
trillville pushed a commit that referenced this pull request Jan 19, 2024
…ts (#62654)

this pr will update how projects are created so that new javascript
platform projects have some of the inbound filters turned on by default.
browser extension, health check transaction, legacy browser, and web
crawler filters will be on by default for these new javascript based
projects. it will not impact projects of any other platform, nor will it
change the filters for any existing project.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants