Skip to content

Inbound Filter for HealthChecks #46731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matejminar opened this issue Apr 2, 2023 · 5 comments
Closed

Inbound Filter for HealthChecks #46731

matejminar opened this issue Apr 2, 2023 · 5 comments
Assignees

Comments

@matejminar
Copy link
Member

matejminar commented Apr 2, 2023

As a user, I want to be able to filter out health check transactions using inbound filters, so they don’t count towards my quota.

Acceptance Criteria:

  • a new inbound filter is added to filter our health check transactions (same way to identify as for DS)
  • the control is just a toggle (ON/OFF)
  • By default, the filter is OFF
  • the new filter is only available for customers on Business plans and is disabled for others. available for all plans
  • this will be under Filters (not Custom Filters)

Image

### Tasks
- [ ] https://github.com/getsentry/sentry/issues/49080
- [ ] https://github.com/getsentry/sentry/issues/49081
- [ ] https://github.com/getsentry/sentry/issues/49082
- [ ] https://github.com/getsentry/relay/pull/2118
- [ ] https://github.com/getsentry/sentry/issues/49089
- [ ] https://github.com/getsentry/sentry/issues/51243
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ale-cota
Copy link
Contributor

After more recent discussion, we've decided to make this filter also available for customers on Team, not just Business.

@ale-cota
Copy link
Contributor

@thinkocapo was asking if we can include ping also to the health check regex list getsentry/relay#2227

@iambriccardo, @matejminar any concerns about that?

@matejminar
Copy link
Member Author

any concerns about that?

nope, added a subtask 👍

we've decided to make this filter also available for customers on Team, not just Business.

also Developer, so essentially no plan gate, right?

@ale-cota
Copy link
Contributor

Yes, no plan gate, like all the other non-custom filters.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants