Skip to content

fix(node): import worker_threads and fix node v14 types #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(node): import worker_threads and fix node v14 types #10791

merged 1 commit into from
Feb 22, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 22, 2024

Ref #10046

Since v8 increases our minimum supported node version, we no longer need to conditionally dynamicRequire the worker_threads module.

@timfish timfish mentioned this pull request Feb 22, 2024
Closed
@timfish timfish marked this pull request as ready for review February 22, 2024 15:01
@AbhiPrasad AbhiPrasad merged commit dddac2c into getsentry:develop Feb 22, 2024
@timfish timfish deleted the fix/worker-import-and-types branch February 22, 2024 15:46
@timfish timfish mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad