-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
Meta: BreakingPackage: nodeIssues related to the Sentry Node SDKIssues related to the Sentry Node SDK
Milestone
Description
Which SDK are you using?
@sentry/node
SDK Version
lastest
Steps to Reproduce
This code was added to fix webpack build errors in node < v12
sentry-javascript/packages/node/src/integrations/anr/index.ts
Lines 25 to 31 in 4f92ff0
/** | |
* We need to use dynamicRequire because worker_threads is not available in node < v12 and webpack error will when | |
* targeting those versions | |
*/ | |
function getWorkerThreads(): WorkerThreads { | |
return dynamicRequire(module, 'worker_threads'); | |
} |
Unfortunatly this causes runtime issues:
getsentry/sentry-electron#828
Expected Result
Should not error
Actual Result
This can just be removed for the next major since we only support Node versions where worker_threads
is available
Metadata
Metadata
Assignees
Labels
Meta: BreakingPackage: nodeIssues related to the Sentry Node SDKIssues related to the Sentry Node SDK