This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Don't set lastEventId for transactions #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/2zXGaNWqoMMetMvn8p897PU5S9np |
marandaneto
commented
Sep 9, 2021
marandaneto
commented
Sep 9, 2021
| @@ -184,11 +184,14 @@ keep track of it themselves. | |||
| - This function returns a header (string) `sentry-trace` | |||
| - The value should be the trace header string of the `Span` that is currently on the `Scope` | |||
|
|
|||
| - `Hub` → Introduce a method called `startTransaction` | |||
| - Introduce a method called `startTransaction` | |||
There was a problem hiding this comment.
since the section is Hub Changes, no need to arrow it
rhcarvalho
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lastEventIdis often used for reporting a user feedback dialog or related use cases. We decided not to updateHub.lastEventIdfor transactions to keep that workflow working.