Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Don't set lastEventId for transactions #430

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Don't set lastEventId for transactions #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b6504
Update index.mdx
marandaneto Sep 9, 2021
ea1e566
Update src/docs/sdk/performance/index.mdx
marandaneto Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/docs/sdk/performance/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,14 @@ keep track of it themselves.
- This function returns a header (string) `sentry-trace`
- The value should be the trace header string of the `Span` that is currently on the `Scope`

- `Hub` → Introduce a method called `startTransaction`
- Introduce a method called `startTransaction`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the section is Hub Changes, no need to arrow it

- Takes the same two arguments as `Sentry.startTransaction`
- Creates a new `Transaction` instance
- Should implement sampling as described in more detail in the 'Sampling' section of this document

- Modify the method called `captureEvent` or `captureTransaction`
- Don't set `lastEventId` for transactions

<!--
NOTE: we may omit this as a deprecated API replaced by `startTransaction` and
`transaction.startChild`, or embrace it as a shortcut for creating a span that
Expand Down