-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feat: parseJson #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat: parseJson #2293
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
536ff70
refactor get_env
odyslam 3c38d0c
feat: test all possible types
odyslam 5bd287c
chore: add jsonpath
odyslam 1001eaf
feat: parse JSON paths to abi-encoded bytes
odyslam 67a9687
feat: flat nested json into a vec of <Value, abi_type>
odyslam bb94a01
fix: support nested json objects as tuples
odyslam 58428b9
chore: add test for nested object
odyslam e18f40e
feat: function overload to load entire json
odyslam 6e3fcb8
fix: minor improvements
odyslam dfb551e
chore: add comments
odyslam f625745
chore: forge fmt
odyslam 8035fe8
feat: writeJson(), without tests
odyslam b4e882d
fix: remove commented-out test
odyslam fa2a2b8
fix: improve error handling
odyslam aba4beb
fix: address Matt's comments
odyslam 3792d56
fix: bool
odyslam fa15e22
chore: remove writeJson code
odyslam 2573fc7
fix: cherry pick shenanigan
odyslam 05e72a4
chore: format, lint, remove old tests
odyslam 4389672
fix: cargo clippy
odyslam 7403c0b
fix: json file test
mattsse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(arbitrary comment location to start a thread)
Have not take a close look at this yet, but just wanted to comment on this:
I think ethers.js has a good convention for distinguishing hex strings that are numbers from hex strings that are bytes. From their docs:
So we can use the same convention for json parsing / script output writing. I quickly sanity checked based on that portion of their docs, but would love someone to double check that / confirm it's a good approach here