Skip to content

Conversation

@prabhupant
Copy link
Contributor

Fixes #5540

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

removes unused line 24100 from API blueprints

Changes proposed in this pull request:

  • removes unused line 24100 from API blueprints

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (development@c8bfed7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #5541   +/-   ##
==============================================
  Coverage               ?   63.21%           
==============================================
  Files                  ?      265           
  Lines                  ?    12733           
  Branches               ?        0           
==============================================
  Hits                   ?     8049           
  Misses                 ?     4684           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bfed7...da84f3f. Read the comment docs.

@prabhupant
Copy link
Contributor Author

@iamareebjamal @srv-twry please review :)

@iamareebjamal
Copy link
Member

API docs development and tests are great, but we require more focus on server issues and code :)

@iamareebjamal iamareebjamal merged commit 25b30f6 into fossasia:development Jan 26, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 29, 2019
mrsaicharan1 added a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
removed unnecessary import

Add seed data for custom placeholders (fossasia#5533)

Disable registrat constraint to update attendees (fossasia#5544)

Frontend follows a flow where non registrar user has to edit an attendee while placing an order.

remove marketer and service fee constraints

Currently, the APIs are not functioning correctly with these intricate configurations.

docs(api): Remove unused line no 24100 in API blueprint (fossasia#5541)

Orders API: Remove verified user constraint (fossasia#5548)

Lax permissions to view discount codes (fossasia#5551)

Read from environment variables when creating the super admin user

Added test database docs for running tests locally (fossasia#5539)

* Added package in local installation docs

* Added test for authentication

* Added docstring for auth test

* Unused modules of auth test removed

* Changed module import style

* test exception handled

* User import

* Whitespace commit

* Add test database instructions

* Update local.md

* Export csv support for sessions

* removed unused packages

* continuation line indent'

* removed test doc commmit to separate PR

* Added test database docs

* Added instructions for test database docs
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
…ia#5512)

Added package in local installation docs

Added test for authentication

Added docstring for auth test

Unused modules of auth test removed

Added package in local installation docs (fossasia#5515)

Changed module import style

test exception handled

User import

Whitespace commit

Export csv support for sessions

Add test database instructions

Update local.md

Added test for authentication (fossasia#5517)

* Added package in local installation docs

* Added test for authentication

* Added docstring for auth test

* Unused modules of auth test removed

* Changed module import style

* test exception handled

* User import

* Whitespace commit

Remove authorisation constraint for discount and access code list

Fix Admin Sales Api (fossasia#5528)

Add hooks for admin statistics (fossasia#5530)

removed unused packages

continuation line indent'

removed test doc commmit to separate PR

Removed redundant print statement

Add seed data for custom placeholders (fossasia#5533)

Disable registrat constraint to update attendees (fossasia#5544)

Frontend follows a flow where non registrar user has to edit an attendee while placing an order.

remove marketer and service fee constraints

Currently, the APIs are not functioning correctly with these intricate configurations.

docs(api): Remove unused line no 24100 in API blueprint (fossasia#5541)

Orders API: Remove verified user constraint (fossasia#5548)

Lax permissions to view discount codes (fossasia#5551)

Read from environment variables when creating the super admin user

Added test database docs for running tests locally (fossasia#5539)

* Added package in local installation docs

* Added test for authentication

* Added docstring for auth test

* Unused modules of auth test removed

* Changed module import style

* test exception handled

* User import

* Whitespace commit

* Add test database instructions

* Update local.md

* Export csv support for sessions

* removed unused packages

* continuation line indent'

* removed test doc commmit to separate PR

* Added test database docs

* Added instructions for test database docs

Removed stream response

removed unnecessary import

Add seed data for custom placeholders (fossasia#5533)

Disable registrat constraint to update attendees (fossasia#5544)

Frontend follows a flow where non registrar user has to edit an attendee while placing an order.

remove marketer and service fee constraints

Currently, the APIs are not functioning correctly with these intricate configurations.

docs(api): Remove unused line no 24100 in API blueprint (fossasia#5541)

Orders API: Remove verified user constraint (fossasia#5548)

Lax permissions to view discount codes (fossasia#5551)

Read from environment variables when creating the super admin user

Added test database docs

Added fields for csv export sessions
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused line in API Blueprints

3 participants