Skip to content

Conversation

@prabhupant
Copy link
Contributor

Fixes #5532

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

adding seed data of custom placeholders for development

Changes proposed in this pull request:

  • adding seed data of custom placeholders for development

@prabhupant prabhupant force-pushed the custom-placeholder-seed-data branch 2 times, most recently from 775721d to ddc458b Compare January 23, 2019 03:47
@prabhupant prabhupant force-pushed the custom-placeholder-seed-data branch from f445a1c to 2ff0317 Compare January 23, 2019 04:17
@prabhupant prabhupant force-pushed the custom-placeholder-seed-data branch from 3867a69 to c2a2ff7 Compare January 23, 2019 04:30
populate_db.py Outdated


def create_custom_placeholders():
custom_placeholder, _ = get_or_create(CustomPlaceholder, name='Hills', original_image_url='https://www.w3schools.com/html/pic_mountain.jpg', event_sub_topic_id=1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (166 > 120 characters)

@fossasia fossasia deleted a comment Jan 23, 2019
@prabhupant prabhupant force-pushed the custom-placeholder-seed-data branch from cc4325f to 2a3b119 Compare January 23, 2019 04:40
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #5533 into development will increase coverage by 0.08%.
The diff coverage is 87.5%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5533      +/-   ##
===============================================
+ Coverage        63.13%   63.21%   +0.08%     
===============================================
  Files              265      265              
  Lines            12726    12733       +7     
===============================================
+ Hits              8034     8049      +15     
+ Misses            4692     4684       -8
Impacted Files Coverage Δ
populate_db.py 78.9% <87.5%> (+0.2%) ⬆️
app/models/custom_placeholder.py 93.1% <0%> (+31.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051d69e...516942d. Read the comment docs.

@prabhupant
Copy link
Contributor Author

@iamareebjamal @srv-twry please review :)

@prabhupant prabhupant force-pushed the custom-placeholder-seed-data branch from e38cf3e to 22c51a7 Compare January 24, 2019 14:28
@prabhupant
Copy link
Contributor Author

@srv-twry fixed it...please review again :)

@iamareebjamal iamareebjamal merged commit c8bfed7 into fossasia:development Jan 24, 2019
@fossasia fossasia deleted a comment Jan 25, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 29, 2019
mrsaicharan1 added a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
removed unnecessary import

Add seed data for custom placeholders (fossasia#5533)

Disable registrat constraint to update attendees (fossasia#5544)

Frontend follows a flow where non registrar user has to edit an attendee while placing an order.

remove marketer and service fee constraints

Currently, the APIs are not functioning correctly with these intricate configurations.

docs(api): Remove unused line no 24100 in API blueprint (fossasia#5541)

Orders API: Remove verified user constraint (fossasia#5548)

Lax permissions to view discount codes (fossasia#5551)

Read from environment variables when creating the super admin user

Added test database docs for running tests locally (fossasia#5539)

* Added package in local installation docs

* Added test for authentication

* Added docstring for auth test

* Unused modules of auth test removed

* Changed module import style

* test exception handled

* User import

* Whitespace commit

* Add test database instructions

* Update local.md

* Export csv support for sessions

* removed unused packages

* continuation line indent'

* removed test doc commmit to separate PR

* Added test database docs

* Added instructions for test database docs
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
…ia#5512)

Added package in local installation docs

Added test for authentication

Added docstring for auth test

Unused modules of auth test removed

Added package in local installation docs (fossasia#5515)

Changed module import style

test exception handled

User import

Whitespace commit

Export csv support for sessions

Add test database instructions

Update local.md

Added test for authentication (fossasia#5517)

* Added package in local installation docs

* Added test for authentication

* Added docstring for auth test

* Unused modules of auth test removed

* Changed module import style

* test exception handled

* User import

* Whitespace commit

Remove authorisation constraint for discount and access code list

Fix Admin Sales Api (fossasia#5528)

Add hooks for admin statistics (fossasia#5530)

removed unused packages

continuation line indent'

removed test doc commmit to separate PR

Removed redundant print statement

Add seed data for custom placeholders (fossasia#5533)

Disable registrat constraint to update attendees (fossasia#5544)

Frontend follows a flow where non registrar user has to edit an attendee while placing an order.

remove marketer and service fee constraints

Currently, the APIs are not functioning correctly with these intricate configurations.

docs(api): Remove unused line no 24100 in API blueprint (fossasia#5541)

Orders API: Remove verified user constraint (fossasia#5548)

Lax permissions to view discount codes (fossasia#5551)

Read from environment variables when creating the super admin user

Added test database docs for running tests locally (fossasia#5539)

* Added package in local installation docs

* Added test for authentication

* Added docstring for auth test

* Unused modules of auth test removed

* Changed module import style

* test exception handled

* User import

* Whitespace commit

* Add test database instructions

* Update local.md

* Export csv support for sessions

* removed unused packages

* continuation line indent'

* removed test doc commmit to separate PR

* Added test database docs

* Added instructions for test database docs

Removed stream response

removed unnecessary import

Add seed data for custom placeholders (fossasia#5533)

Disable registrat constraint to update attendees (fossasia#5544)

Frontend follows a flow where non registrar user has to edit an attendee while placing an order.

remove marketer and service fee constraints

Currently, the APIs are not functioning correctly with these intricate configurations.

docs(api): Remove unused line no 24100 in API blueprint (fossasia#5541)

Orders API: Remove verified user constraint (fossasia#5548)

Lax permissions to view discount codes (fossasia#5551)

Read from environment variables when creating the super admin user

Added test database docs

Added fields for csv export sessions
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding seed data for development of custom placeholders

4 participants