feat: add decomposition preset for external service registration #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w isAddressable (#1467) * fix: add workflow flow actions and allow isAddressable * fix: add workflow flow actions
* chore: register md apis to metadata registry * Update metadataRegistry.json chore:empty commit
…#1480) * fix: resolve strict dirs before suffixes for potential metadata files * fix: do not reuse suffixType if no match
…into phale/decompose-esr
* chore: reset snapshots to main * fix: deploy ESR yaml and -meta * test: fix registry test * chore: bump core * chore: always decompose to yaml The schema property contents in an esr can be either yaml of json. For simplicity, given the property alwasy represents an Open API spec, the decomposed format of schema will be yaml. Recomposition will use an existing xml property, schemaUploadFileExtension, to determine the format when build the MD type. * chore: add missing expected artifacts --------- Co-authored-by: peternhale <[email protected]>
shetzel
approved these changes
Jan 24, 2025
| const xmlContent = { ...(await component.parseXml<ESR>()).ExternalServiceRegistration }; | ||
|
|
||
| // Extract schema content | ||
| // eslint-disable-next-line no-underscore-dangle |
| type ESR = JsonMap & { | ||
| ExternalServiceRegistration: ExternalServiceRegistration & | ||
| { schemaUploadFileExtension: SchemaType }; | ||
| }; |
Contributor
There was a problem hiding this comment.
Any way this can be a stronger type? JsonMap is pretty generic.
| after(async () => { | ||
| await Promise.all([ | ||
| // fs.promises.rm(path.join(testDir, 'force-app'), { recursive: true, force: true }), | ||
| // fs.promises.rm(path.join(testDir, MDAPI_OUT), { recursive: true, force: true }), |
Contributor
There was a problem hiding this comment.
Do these need to be uncommented now or deleted?
Contributor
Author
There was a problem hiding this comment.
That's how they were when I copied the test from another. I can uncomment them if that is "typical"
WillieRuemmele
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a source behavior preset for ExternalServiceRegistration MD type. The new decomposition will save the contents of the ESR.schema xml entry into a yaml file as the same as the ESR.
Once enabled, the new transformer will be responsible to converting the MD to source and back to metadata format.
What issues does this PR fix or reference?
@W-17454236@
Functionality Before
The ESR MD type was presented in only xml format
Functionality After
The ESR MD type can now be presented in its MD format or, with these changes, be presented as a yaml file for editing along with the remaining xml elements in the sibling MD xml file