Skip to content

Conversation

@iowillhoit
Copy link
Contributor

We had a few GHA failures because of a newline in the LICENSE.md file. This change only checks for changes in the METADATA_SUPPORT.md file before attempting to commit

Example failure:
https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/12589411545/job/35089181629#step:9:17

@iowillhoit iowillhoit requested a review from a team as a code owner January 6, 2025 19:31
@iowillhoit iowillhoit merged commit a806aaa into main Jan 6, 2025
53 checks passed
@iowillhoit iowillhoit deleted the ew/git-status-check branch January 6, 2025 20:12
peternhale pushed a commit that referenced this pull request Jan 9, 2025
peternhale added a commit that referenced this pull request Jan 24, 2025
* chore: wip

* chore: license year

* chore(release): 12.11.0 [skip ci]

* chore: only check md file (#1475)

* fix: add workflow flow actions to decomposed workflow preset and allow isAddressable (#1467)

* fix: add workflow flow actions and allow isAddressable

* fix: add workflow flow actions

* chore(release): 12.11.1 [skip ci]

* W-17279149 Register MD APIs to metadata registry (#1472)

* chore: register md apis to metadata registry

* Update metadataRegistry.json

chore:empty commit

* chore(release): 12.11.2 [skip ci]

* chore: auto-update metadata coverage in METADATA_SUPPORT.md [no ci]

* fix: update snapshot (#1478)

* chore(release): 12.11.3 [skip ci]

* feat(mdTypes): register tua viz and ws metadata types (#1479)

* chore(release): 12.12.0 [skip ci]

* chore: auto-update metadata coverage in METADATA_SUPPORT.md [no ci]

* fix: resolve strict dirs before suffixes for potential metadata files (#1480)

* fix: resolve strict dirs before suffixes for potential metadata files

* fix: do not reuse suffixType if no match

* chore(release): 12.12.1 [skip ci]

* chore: wip

* chore: wip

* chore: wip

* chore: encoded in MD, chars in SD (#1485)

* chore: wip

* chore: wip

* chore: update md xml to include xml header

* chore: temp (#1490)

* chore: wip

* Wr/decompose esr (#1492)

* chore: reset snapshots to main

* fix: deploy ESR yaml and -meta

* test: fix registry test

* chore: bump core

* chore: always decompose to yaml

The schema property contents in an esr can be either yaml of json.
For simplicity, given the property alwasy represents an Open API spec, the decomposed format of schema will be yaml.
Recomposition will use an existing xml property, schemaUploadFileExtension, to determine the format when build the MD type.

* chore: add missing expected artifacts

---------

Co-authored-by: peternhale <[email protected]>

* chore: fix test

* chore: address review suggestions

---------

Co-authored-by: Willhoit <[email protected]>
Co-authored-by: svc-cli-bot <[email protected]>
Co-authored-by: Matt Carvin <[email protected]>
Co-authored-by: Idan Roas <[email protected]>
Co-authored-by: Willie Ruemmele <[email protected]>
Co-authored-by: PKV <[email protected]>
Co-authored-by: Steve Hetzel <[email protected]>
@iowillhoit iowillhoit changed the title Only check md file for changes W-17672123 Only check md file for changes Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants