Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@philip-peterson
Copy link

@philip-peterson philip-peterson commented Oct 28, 2020

Description

This PR adds support for loading data directly via the underlying OS's WebView API if possible.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla
Copy link

google-cla bot commented Oct 28, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ndusart
Copy link

ndusart commented Jan 21, 2021

Is there a possibility that this PR can be merged anytime soon ?
From the CI, it seems some incompatibilities with dependencies versions. Could this be fixed with a rebase ?

@philip-peterson
Copy link
Author

I never got this feature working unfortunately, and since I'm not writing code for the Flutter ecosystem anymore, this PR is up for grabs to whoever can work on it.

@stuartmorgan-g stuartmorgan-g added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! It sounds from the above like there are no plans to complete this PR, so I'm going to close it. If anyone is interested in moving forward with it, please fork it and submit a new, complete PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow loading data to webviews

3 participants