-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[webview_flutter] Expose loadData function for webviews #2463
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
8474b62 to
d4ad3b1
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Nice |
|
That'd be amazing 👏 |
d4ad3b1 to
8461a0d
Compare
|
I've rebased this feature-branch on the latest master. Please review :) |
8461a0d to
f4d4064
Compare
|
I think #3214 is better and should be merged instead of this. |
f4d4064 to
5c8d136
Compare
|
Thanks for the submission! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
Can you clarify the question here? What is the motivation for this exception?
As you noted originally, this PR isn't ready for review yet as it's missing tests. It looks like it should be relatively straightforward to review once they are ready though. |
|
/cc @mvanbeusekom |
|
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
Description
Expose
loadDataon the webview controller. This allows developers to load html directly into the webview.This is a draft PR. I'm using this change in a product, but it is not ready to be merged into flutter/plugins yet. For example: e2e tests for this feature are still missing.
I wanted to open this PR anyway to get early feedback. I have seen @amirh reply to earlier PR's regarding this feature. I hope you can give some feedback on this approach?
For example; should we make loadUrl and loadData throw an exception when the other one was used before? We can keep that knowledge on the dart side and just throw a dart exception, or should it be tried and possibly return an error depending on the platform implementation handles it?
Related Issues
This fixes flutter/flutter#32827
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?