Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@GeertJohan
Copy link

@GeertJohan GeertJohan commented Jan 13, 2020

Description

Expose loadData on the webview controller. This allows developers to load html directly into the webview.

This is a draft PR. I'm using this change in a product, but it is not ready to be merged into flutter/plugins yet. For example: e2e tests for this feature are still missing.

I wanted to open this PR anyway to get early feedback. I have seen @amirh reply to earlier PR's regarding this feature. I hope you can give some feedback on this approach?

For example; should we make loadUrl and loadData throw an exception when the other one was used before? We can keep that knowledge on the dart side and just throw a dart exception, or should it be tried and possibly return an error depending on the platform implementation handles it?

Related Issues

This fixes flutter/flutter#32827

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@GeertJohan GeertJohan force-pushed the feature/webview-loaddata branch from 8474b62 to d4ad3b1 Compare January 13, 2020 11:03
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ahyenz
Copy link

ahyenz commented Jan 26, 2020

Nice

@GeertJohan GeertJohan requested a review from amirh January 27, 2020 10:40
@CanRau
Copy link

CanRau commented Feb 15, 2020

That'd be amazing 👏

@GeertJohan
Copy link
Author

I've rebased this feature-branch on the latest master. Please review :)

@GeertJohan GeertJohan force-pushed the feature/webview-loaddata branch from 8461a0d to f4d4064 Compare April 3, 2020 09:40
@GeertJohan
Copy link
Author

I think #3214 is better and should be merged instead of this.

@GeertJohan GeertJohan force-pushed the feature/webview-loaddata branch from f4d4064 to 5c8d136 Compare January 12, 2021 13:51
@stuartmorgan-g stuartmorgan-g added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

For example; should we make loadUrl and loadData throw an exception when the other one was used before?

Can you clarify the question here? What is the motivation for this exception?

Please review :)

As you noted originally, this PR isn't ready for review yet as it's missing tests. It looks like it should be relatively straightforward to review once they are ready though.

@stuartmorgan-g stuartmorgan-g removed the request for review from amirh June 29, 2021 19:50
@stuartmorgan-g
Copy link
Contributor

/cc @mvanbeusekom

@stuartmorgan-g
Copy link
Contributor

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow loading data to webviews

5 participants