This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher] Open url in same window when browser is in standalone mode. #2656
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3566fc0
Open url in same window when browser is in standalone mode.
tugorez d3b3e87
fixed analyzer issues
tugorez 4c1e78d
Expose navigator.standalone for testing
tugorez ccefd0d
fix test descriptions
tugorez 48fd041
reset the navigator state
tugorez beb27b2
Move navigator to lib/src
tugorez 7d737be
Update CHANGELOG.md
tugorez 1f18d28
Update CHANGELOG.md
tugorez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| # 0.1.1+2 | ||
|
|
||
| - Open urls with target "_top" on iOS PWAs. | ||
|
|
||
| # 0.1.1+1 | ||
|
|
||
| - Make the pedantic dev_dependency explicit. | ||
|
|
||
15 changes: 15 additions & 0 deletions
15
packages/url_launcher/url_launcher_web/lib/src/navigator.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| @JS() | ||
| library navigator; | ||
|
|
||
| import 'package:js/js.dart'; | ||
| import 'package:meta/meta.dart'; | ||
|
|
||
| @JS('window.navigator.standalone') | ||
| external bool get _standalone; | ||
|
|
||
| /// The window.navigator.standalone DOM property. | ||
| bool get standalone => _standalone ?? false; | ||
|
|
||
| @visibleForTesting | ||
| @JS('window.navigator.standalone') | ||
| external set standalone(bool enabled); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.