This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher] Open url in same window when browser is in standalone mode. #2656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df5b99e to
331d38a
Compare
ditman
reviewed
Apr 17, 2020
Member
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looking great, I've added only a few comments!
ditman
reviewed
Apr 17, 2020
ditman
reviewed
Apr 17, 2020
ditman
approved these changes
Apr 22, 2020
Member
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with my phone and an emulator and it seems to fix the issue! I'll merge this as soon as the tree goes green again.
Thanks for the contribution @tugorez!
13 tasks
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users using this plugin on iOS PWAs are experiencing blank screens when a url is opened on another app and then they try to go back. It seems to be an well known issue on iOS [1] and [2] as reference. In the meantime we can overcome this limitation by modifying the target to "_top" according to [2] (solution manually verified). This PR does exactly that, verifies if the user is running a PWA in iOS and if so it will open the url with "_top" as target.
[1] https://stackoverflow.com/questions/55517297/mailto-doesnt-work-when-website-launched-from-ios-home-screen/56153685#56153685
[2] https://stackoverflow.com/questions/56220862/ios-pwa-open-maps-returns-to-blank-screen
Related Issues
flutter/flutter#51461
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?