Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@tugorez
Copy link
Contributor

@tugorez tugorez commented Apr 15, 2020

Description

Users using this plugin on iOS PWAs are experiencing blank screens when a url is opened on another app and then they try to go back. It seems to be an well known issue on iOS [1] and [2] as reference. In the meantime we can overcome this limitation by modifying the target to "_top" according to [2] (solution manually verified). This PR does exactly that, verifies if the user is running a PWA in iOS and if so it will open the url with "_top" as target.

[1] https://stackoverflow.com/questions/55517297/mailto-doesnt-work-when-website-launched-from-ios-home-screen/56153685#56153685
[2] https://stackoverflow.com/questions/56220862/ios-pwa-open-maps-returns-to-blank-screen

Related Issues

flutter/flutter#51461

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@tugorez tugorez changed the title [url_launcher][WIP Open url in same window when browser is in standalone mode. [url_launcher][WIP] Open url in same window when browser is in standalone mode. Apr 15, 2020
@tugorez tugorez force-pushed the fix/51461 branch 4 times, most recently from df5b99e to 331d38a Compare April 15, 2020 18:36
@tugorez tugorez changed the title [url_launcher][WIP] Open url in same window when browser is in standalone mode. [url_launcher] Open url in same window when browser is in standalone mode. Apr 16, 2020
@ditman ditman self-requested a review April 17, 2020 17:52
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looking great, I've added only a few comments!

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with my phone and an emulator and it seems to fix the issue! I'll merge this as soon as the tree goes green again.

Thanks for the contribution @tugorez!

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants