-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Feature/web view failure listener #2416
Feature/web view failure listener #2416
Conversation
Feature/web view failure listener
# Conflicts: # packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebViewClient.java # packages/webview_flutter/ios/Classes/FLTWKNavigationDelegate.m # packages/webview_flutter/lib/src/webview_method_channel.dart # packages/webview_flutter/lib/webview_flutter.dart # packages/webview_flutter/test/webview_flutter_test.dart
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
|
@just-kip i updated pr, can you accept license? |
|
@googlebot I consent. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed |
|
@googlebot I fixed |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog. It looks like in the meantime this was implemented in #2639, so I'm going to close this as obsolete. Apologies for the duplicated effort. |
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?