This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] onPageStarted, onPageReceiveError callbacks. #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-kip
force-pushed
the
feature/web_view_failure_listener
branch
from
bbe8949 to
e5a52f7
Compare
This was referenced Jul 11, 2019
Contributor
|
Thanks for the contribution! I started reviewing this and left a few comments. I'm following the initial PR review policy, this PR isn't trivial to review so I'm labeling it with "backlog" and we will prioritize according to the issue's priority. Relevant issue: flutter/flutter#25100 |
amirh
reviewed
Jul 11, 2019
| /// Invoked by [WebViewPlatformController] when a page has finished loading. | ||
| void onPageFinished(String url); | ||
|
|
||
| void onPageReceiveError({String url, int code, String description}); |
| /// Signature for when a [WebView] receive a error. | ||
| /// Code may be NSURLErrorDomain code or const from Android WebViewClient or http status code. | ||
| /// Description is optional | ||
| typedef void PageReceiveErrorCallback(String url, int code, String description); |
Contributor
There was a problem hiding this comment.
Do we have a guarantee that no WebResourceError code will ever be a valid HTTP response code?
I think we should give developers a single way to detect errors that are the same on all platforms (e.g too many redirects).
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add onPageStarted, onPageReceivedError callbacks.
You can catch iOS or Android specific error сodes and http status codes.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?