-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[ImagePicker] Captured Video quality and duration support #2336
[ImagePicker] Captured Video quality and duration support #2336
Conversation
… with the new parameters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
The video duration has been worked on #2048 and it is close to be landed. |
@cyanglaz I will wait until his PR merged into master, and I will update mine, and resolve any conflicts if required. is it Ok? |
|
@0xcodezero FYI the video duration is landed in #2643. You can rebase and focus this PR on quality now. |
|
@cyanglaz hi! Is there a possibility that this PR will be merged? quality parameter for recorded video would be a stunning feature! |
|
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
Description
*Starting using the Plugin, I found that there are no extra parameters could be passed to the pickVideo function. This behavior limits the usage of the library especially having no record duration could lead to a huge file size that is very hard to upload to a server.
In this PR, I have implemented optional two parameters for pickVideo function (quality, durationInSeconds) which were covered in the three levels (Dart, iOS Objective-C, and Android Java Library) that controlled the outcome video recorded from the device Camera
The changes are on iOS (ImagePickerPlugin.m), Android(ImagePickerDelegate.java), Dart (image_picker.dart),(test/image_picker_test.dart).
Being implemented as optional parameters, it will not break any previous code implementations and supports the default behavior as currently implemented if the parameters are not passed. (High-Quality video, No duration record duration).
*
Related Issues
flutter/flutter#40035
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?