Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@0xcodezero
Copy link

Description

*Starting using the Plugin, I found that there are no extra parameters could be passed to the pickVideo function. This behavior limits the usage of the library especially having no record duration could lead to a huge file size that is very hard to upload to a server.

In this PR, I have implemented optional two parameters for pickVideo function (quality, durationInSeconds) which were covered in the three levels (Dart, iOS Objective-C, and Android Java Library) that controlled the outcome video recorded from the device Camera

The changes are on iOS (ImagePickerPlugin.m), Android(ImagePickerDelegate.java), Dart (image_picker.dart),(test/image_picker_test.dart).

Being implemented as optional parameters, it will not break any previous code implementations and supports the default behavior as currently implemented if the parameters are not passed. (High-Quality video, No duration record duration).
*

Related Issues

flutter/flutter#40035

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@0xcodezero 0xcodezero requested a review from cyanglaz as a code owner December 3, 2019 11:37
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Dec 3, 2019
@cyanglaz
Copy link
Contributor

cyanglaz commented Dec 3, 2019

The video duration has been worked on #2048 and it is close to be landed.
@0xcodezero Do you want to modify your PR to only add quality?

@0xcodezero
Copy link
Author

The video duration has been worked on #2048 and it is close to be landed.
@0xcodezero Do you want to modify your PR to only add quality?

@cyanglaz I will wait until his PR merged into master, and I will update mine, and resolve any conflicts if required. is it Ok?

@0xcodezero 0xcodezero requested a review from ened December 5, 2019 08:31
@cyanglaz
Copy link
Contributor

@0xcodezero FYI the video duration is landed in #2643. You can rebase and focus this PR on quality now.

@fedeandreocci
Copy link

@cyanglaz hi! Is there a possibility that this PR will be merged? quality parameter for recorded video would be a stunning feature!

@stuartmorgan-g
Copy link
Contributor

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants