[image_picker] Added maxDuration property to pickVideo method #2048

derTuca · 2019-09-09T12:44:04Z

Description

Adds a maxDuration property so a maximum recording duration can be set.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

This way, we can limit the length of recorded video to a certain number of seconds.

qwerqwq · 2019-09-12T03:01:26Z

image_picker有压缩图片的api吗

cyanglaz

Thank you for the PR. Looks good overall, left some comments.

packages/image_picker/ios/Classes/ImagePickerPlugin.m

packages/image_picker/lib/image_picker.dart

klaszlo8207 · 2019-09-14T10:02:41Z

Finally, this is awesome :) When will be this feature available? I need this ASAP. Thanks

Replaced double with NSTimeInterval

cyanglaz

Took another round of review, left some more comments.

...s/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

packages/image_picker/example/ios/Runner.xcodeproj/project.pbxproj

klaszlo8207 · 2019-10-08T11:29:46Z

Hey, what's happening with this PR? Nothing? 15 days....

klaszlo8207 · 2019-10-14T08:39:04Z

Any news on this? Please help me

cyanglaz · 2019-10-14T23:23:56Z

@derTuca It is been a while since I reviewed this PR. Do you still want to continue to work on this?

klaszlo8207 · 2019-10-21T10:56:22Z

@cyanglaz can you help me in this PR? It looks like @derTuca has no time for this. Can you fix it and merge to the base code?

Thanks!

cyanglaz · 2019-11-07T20:07:49Z

@derTuca Do you think you still want to work on this?

If anyone is interested to open another PR to work on this, I am happy to review it.

klaszlo8207 · 2019-11-14T08:34:14Z

Can you fix the problems in the conflicting files @cyanglaz? and then just simple attach to the code base? It is a must to have feature, and I need this before last month :)

…ndroid" This reverts commit 953f22a.

derTuca · 2019-11-15T07:35:17Z

Sorry for the huge delays, I am caught up with some stuff at this time. I have adopted the proposed changes, @cyanglaz if you could review it again it would be great.

cyanglaz

LGTM! Thanks a lot for the good work! Please rebase master and fix any CI issues, I will merge this once the CI is green!

…_max_duration

ened · 2019-12-11T06:40:42Z

Hi @derTuca could you kindly rebase to latest master and have another look at the CHANGELOG.md changes? The formatting for many entries is still a bit off.
The plugins repository is now building nicely again, so we can merge this PR soon. Thank you!

cyanglaz · 2019-12-17T17:58:45Z

@derTuca Please also add a jUnit test to test the max duration property in Android.

…_max_duration

…s into image_picker_max_duration

derTuca · 2019-12-31T16:18:09Z

@cyanglaz I haven't done much testing with Java, so I need some help with how to mock the ImagePickerDelegate class properly; I don't know if I just need to use @mock or if I need to do a more...proper...initialization of the constructor's args.

cyanglaz · 2020-01-23T20:58:56Z

@derTuca There are some existing junit test cases in this plugin. You can take a look and see how they are constructed.

klaszlo8207 · 2020-01-28T13:06:51Z

Hello all, any way to add this PR to the source code now? Last time I wrote was 2019 nov 14. This is very slooooooooooooooow.

…_max_duration # Conflicts: # packages/image_picker/CHANGELOG.md # packages/image_picker/pubspec.yaml

derTuca · 2020-02-02T20:23:06Z

@cyanglaz Done, thanks for the info!

cyanglaz

Thanks for adding the java tests. We can also add iOS unit testing. There should be some unit test cases in this plugin as well.

packages/image_picker/CHANGELOG.md

…_max_duration

derTuca · 2020-02-18T14:00:55Z

Thanks for adding the java tests. We can also add iOS unit testing. There should be some unit test cases in this plugin as well.

Do you have any tips on how I can start on this? I have seen the other tests, but there are none testing passing a parameter to the controller per se (as far as I can tell), and I don't really know what to test here.

cyanglaz · 2020-02-18T17:20:46Z

@derTuca I would:

Create a FLTImagePickerPlugin with some mocking parameters. (Feel free to use OCMock).
Pass maxDuration to the method channel.
Check if the maxDuration of the controller is the same as the one you passed in.

derTuca · 2020-03-17T16:48:07Z

For the life of everything, I swear that (with all the free time everybody suddenly has) I've looked into this, but I can't figure out how to check the duration in the controller. I can do the Android approach, where we just check if it returns the file path with the argument passed, but with the controller being private and all (so I can't mock it), I don't know how to check its maxDuration.

@cyanglaz am I missing the magic sauce? Or is it just straight up not possible to check it without modifying the plugin code?

mehmetf · 2020-03-25T05:43:48Z

FWIW, this is something customer:money cares about. @cyanglaz it would be great if you can help @derTuca here.

cyanglaz · 2020-03-25T17:05:32Z

FWIW, this is something customer:money cares about. @cyanglaz it would be great if you can help @derTuca here.

Sure, I'll move this up in my priority list.

cyanglaz · 2020-03-25T17:07:02Z

@derTuca In my opinion, It is totally legit to modify the code in order to make them testable. Feel free to do so. Let me know if you still face troubles. :)

cyanglaz · 2020-04-03T22:00:16Z

@derTuca Just checking in how you are doing :) Are you able to continue working on this PR?

ngoctranfire · 2020-04-05T11:43:01Z

@derTuca, curious about your progress here too. This is something I'm looking into as well too. If there's something I can help with here, I can try to do so as well too.

cyanglaz · 2020-04-08T18:22:50Z

@derTuca I added the tests and resolved the conflicts for this PR in derTuca#1
Do you mind taking a look and merge?

derTuca · 2020-04-09T18:10:59Z

@derTuca I added the tests and resolved the conflicts for this PR in derTuca#1
Do you mind taking a look and merge?

Merged, sorry for not being able to look into it after all.

cyanglaz · 2020-04-09T19:08:16Z

@derTuca It seems the pull request went to a wrong branch. Could you create another PR to the correct branch to fix that?

derTuca · 2020-04-09T19:21:01Z

Done. #2643.

Added maxDuration property to pickVideo method

1634873

This way, we can limit the length of recorded video to a certain number of seconds.

derTuca requested a review from cyanglaz as a code owner September 9, 2019 12:44

googlebot added the cla: yes label Sep 9, 2019

BondarenkoStas mentioned this pull request Sep 10, 2019

image_picker video recording time limit flutter/flutter#40149

Closed

cyanglaz suggested changes Sep 13, 2019

View reviewed changes

packages/image_picker/ios/Classes/ImagePickerPlugin.m Outdated Show resolved Hide resolved

packages/image_picker/lib/image_picker.dart Outdated Show resolved Hide resolved

cyanglaz self-assigned this Sep 13, 2019

cyanglaz added the in review label Sep 13, 2019

derTuca added 3 commits September 16, 2019 12:29

Added additional comment on maxDuration purpose

b3e452f

Replaced double with NSTimeInterval

Changed pick intent to open gallery instead of documents on Android

953f22a

Replaced copy-pasted video ref to image

46e5507

cyanglaz reviewed Sep 23, 2019

View reviewed changes

derTuca added 3 commits November 15, 2019 08:21

Revert "Changed pick intent to open gallery instead of documents on A…

09bead9

…ndroid" This reverts commit 953f22a.

Revert project.pbxproj

6e6feee

Add iskindof check for argument

9a449b7

derTuca requested a review from cyanglaz November 16, 2019 15:06

derTuca and others added 2 commits November 16, 2019 16:08

Merge branch 'master' into image_picker_max_duration

d5d3a90

Update AUTHORS

254ffd0

cyanglaz approved these changes Nov 20, 2019

View reviewed changes

derTuca added 3 commits November 26, 2019 21:53

Merge branch 'master' of github.com:flutter/plugins into image_picker…

97cd154

…_max_duration

Added const initializers for Duation

2e03c76

Formatted code using tool

5a88cee

cyanglaz mentioned this pull request Dec 3, 2019

[ImagePicker] Captured Video quality and duration support #2336

Closed

13 tasks

Reverted changelog accidental replace and added author to pubspec

c901384

Chris Yang added 2 commits December 17, 2019 09:56

Update CHANGELOG.md

50a1170

Update CHANGELOG.md

c83d9ee

derTuca added 2 commits December 31, 2019 16:33

Merge branch 'master' of github.com:flutter/plugins into image_picker…

669a420

…_max_duration

Merge branch 'image_picker_max_duration' of github.com:derTuca/plugin…

b6301da

…s into image_picker_max_duration

derTuca added 2 commits February 2, 2020 21:46

Merge branch 'master' of github.com:flutter/plugins into image_picker…

8a0dd18

…_max_duration # Conflicts: # packages/image_picker/CHANGELOG.md # packages/image_picker/pubspec.yaml

Added JUnit test for max duration

1c8c816

cyanglaz reviewed Feb 3, 2020

View reviewed changes

packages/image_picker/CHANGELOG.md Outdated Show resolved Hide resolved

derTuca added 2 commits February 18, 2020 15:51

Updated changelog and pubspec version

8822565

Merge branch 'master' of github.com:flutter/plugins into image_picker…

e7c7532

…_max_duration

derTuca closed this Apr 9, 2020

[image_picker] Added maxDuration property to pickVideo method #2048

[image_picker] Added maxDuration property to pickVideo method #2048

Uh oh!

Conversation

derTuca commented Sep 9, 2019

Description

Related Issues

Checklist

Breaking Change

Uh oh!

qwerqwq commented Sep 12, 2019

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

klaszlo8207 commented Sep 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

klaszlo8207 commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klaszlo8207 commented Oct 14, 2019

Uh oh!

cyanglaz commented Oct 14, 2019

Uh oh!

klaszlo8207 commented Oct 21, 2019

Uh oh!

cyanglaz commented Nov 7, 2019

Uh oh!

klaszlo8207 commented Nov 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derTuca commented Nov 15, 2019

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

ened commented Dec 11, 2019

Uh oh!

cyanglaz commented Dec 17, 2019

Uh oh!

derTuca commented Dec 31, 2019

Uh oh!

cyanglaz commented Jan 23, 2020

Uh oh!

klaszlo8207 commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derTuca commented Feb 2, 2020

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

derTuca commented Feb 18, 2020

Uh oh!

cyanglaz commented Feb 18, 2020

Uh oh!

derTuca commented Mar 17, 2020

Uh oh!

mehmetf commented Mar 25, 2020

Uh oh!

cyanglaz commented Mar 25, 2020

Uh oh!

cyanglaz commented Mar 25, 2020

Uh oh!

cyanglaz commented Apr 3, 2020

Uh oh!

ngoctranfire commented Apr 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klaszlo8207 commented Sep 14, 2019 •

edited

Loading

klaszlo8207 commented Oct 8, 2019 •

edited

Loading

klaszlo8207 commented Nov 14, 2019 •

edited

Loading

klaszlo8207 commented Jan 28, 2020 •

edited

Loading

ngoctranfire commented Apr 5, 2020 •

edited

Loading