[ci] Re-enable wasm and Windows ARM64 tests #9667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issues that caused these tests to be set to bringup have both been resolved, and the tasks have been consistently green recently. See flutter/flutter#170433 See flutter/flutter#134083 Fixes flutter/flutter#170434
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request re-enables wasm and Windows ARM64 tests in the .ci.yaml configuration file. The changes involve removing the bringup: true flag and associated comments from four test targets, which is consistent with the stated goal of the PR. The linked issues provide good context for this change. The modifications are straightforward and appear correct.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 28, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 28, 2025
flutter/packages@963550c...6b2e34e 2025-07-28 [email protected] [interactive_media_ads] Adds support to set general SDK settings (flutter/packages#9648) 2025-07-28 [email protected] Roll Flutter from 20788c0 to cfbaa18 (43 revisions) (flutter/packages#9688) 2025-07-25 [email protected] Roll Flutter (stable) from d7b523b to edada7c (7 revisions) (flutter/packages#9677) 2025-07-25 [email protected] Resolve `android_build_all_packages` Warnings (flutter/packages#9643) 2025-07-25 [email protected] [video_player] Move Android to per-player-instance Pigeon APIs (flutter/packages#9511) 2025-07-24 [email protected] [ci] Re-enable wasm and Windows ARM64 tests (flutter/packages#9667) 2025-07-24 [email protected] Roll Flutter from afba7d7 to 20788c0 (27 revisions) (flutter/packages#9670) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
The issues that caused these tests to be set to bringup have both been resolved, and the tasks have been consistently green recently. See flutter/flutter#170433 See flutter/flutter#134083 Fixes flutter/flutter#170434
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…r#172869) flutter/packages@963550c...6b2e34e 2025-07-28 [email protected] [interactive_media_ads] Adds support to set general SDK settings (flutter/packages#9648) 2025-07-28 [email protected] Roll Flutter from 20788c0 to cfbaa18 (43 revisions) (flutter/packages#9688) 2025-07-25 [email protected] Roll Flutter (stable) from d7b523b to edada7c (7 revisions) (flutter/packages#9677) 2025-07-25 [email protected] Resolve `android_build_all_packages` Warnings (flutter/packages#9643) 2025-07-25 [email protected] [video_player] Move Android to per-player-instance Pigeon APIs (flutter/packages#9511) 2025-07-24 [email protected] [ci] Re-enable wasm and Windows ARM64 tests (flutter/packages#9667) 2025-07-24 [email protected] Roll Flutter from afba7d7 to 20788c0 (27 revisions) (flutter/packages#9670) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…r#172869) flutter/packages@963550c...6b2e34e 2025-07-28 [email protected] [interactive_media_ads] Adds support to set general SDK settings (flutter/packages#9648) 2025-07-28 [email protected] Roll Flutter from 20788c0 to cfbaa18 (43 revisions) (flutter/packages#9688) 2025-07-25 [email protected] Roll Flutter (stable) from d7b523b to edada7c (7 revisions) (flutter/packages#9677) 2025-07-25 [email protected] Resolve `android_build_all_packages` Warnings (flutter/packages#9643) 2025-07-25 [email protected] [video_player] Move Android to per-player-instance Pigeon APIs (flutter/packages#9511) 2025-07-24 [email protected] [ci] Re-enable wasm and Windows ARM64 tests (flutter/packages#9667) 2025-07-24 [email protected] Roll Flutter from afba7d7 to 20788c0 (27 revisions) (flutter/packages#9670) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues that caused these tests to be set to bringup have both been resolved, and the tasks have been consistently green recently.
See flutter/flutter#170433
See flutter/flutter#134083
Fixes flutter/flutter#170434