Resolve android_build_all_packages Warnings
#9643
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR addresses a flaky Android build by updating several Gradle-related versions, which is a good approach. The change to create_all_packages_app_command.dart correctly moves a directory copy operation out of a loop, improving efficiency. However, I've pointed out a logical flaw in the new file/directory deletion logic that could lead to incorrect behavior and suggested a more robust implementation.
.ci/legacy_project/all_packages/android/gradle/wrapper/gradle-wrapper.properties
Show resolved
Hide resolved
jesswrd
changed the title
android_build_all_packages flakeandroid_build_all_packages Warnings
@stuartmorgan-g Instead of changing the tooling, I paired wtih Reid to resolve my local In the meantime, I updated this PR to only address the versioning warnings. That is still a necessary change. |
There was a problem hiding this comment.
LGTM with one nit.
Instead of changing the tooling, I paired wtih Reid to resolve my local
.DS_Storeissue . I reverted the changes to this command. I had thought this could potentially be the source of flaking because I could not build the app locally, but it was due to.DS_Storeissue.
Please feel free to send me a PR that has just those tool changes; there's no reason not to have the tooling be robust against local automatic .DS_Store creation to spare future developers the debugging you went through.
.ci/legacy_project/README.md
Outdated
| one that we support. | ||
| - Modifies `settings.gradle` to upgrade the Android Gradle Plugin (AGP) | ||
| from version 8.3.0 to 8.6.0. If a user runs into an error with the AGP | ||
| version, the warning is clear on how to upgrade the version to one that we support. |
There was a problem hiding this comment.
These should be folded into the bullet points above, just updating the final version. E.g., "... upgrade the Gradle version from 6.7 to 8.7. ...". The goal here isn't to have a history of the specific incremental changes, but a catalog of what is different between a legacy app and the current state.
jesswrd
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/9643, because - The status or check suite Mac_arm64 custom_package_tests master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
flutter/packages@963550c...6b2e34e 2025-07-28 [email protected] [interactive_media_ads] Adds support to set general SDK settings (flutter/packages#9648) 2025-07-28 [email protected] Roll Flutter from 20788c0 to cfbaa18 (43 revisions) (flutter/packages#9688) 2025-07-25 [email protected] Roll Flutter (stable) from d7b523b to edada7c (7 revisions) (flutter/packages#9677) 2025-07-25 [email protected] Resolve `android_build_all_packages` Warnings (flutter/packages#9643) 2025-07-25 [email protected] [video_player] Move Android to per-player-instance Pigeon APIs (flutter/packages#9511) 2025-07-24 [email protected] [ci] Re-enable wasm and Windows ARM64 tests (flutter/packages#9667) 2025-07-24 [email protected] Roll Flutter from afba7d7 to 20788c0 (27 revisions) (flutter/packages#9670) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Addressed versioning warnings by updating the following dependencies to their minimum supported versions: Gradle: 8.7 AGP: 8.6.0 KGP: 2.1.0 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Addressed versioning warnings by updating the following dependencies to their minimum supported versions:
Gradle: 8.7
AGP: 8.6.0
KGP: 2.1.0
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3