[flutter_svg] Fixes typo of allowDrawingOutsideViewBox in doc comments.
#10256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utsideViewBox` in parameter docs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in doc comments for the allowDrawingOutsideViewBox parameter in lib/svg.dart. The package version is also bumped to 2.2.2 and the CHANGELOG.md is updated accordingly. The changes are correct and improve documentation accuracy.
domesticmouse
approved these changes
Oct 18, 2025
stuartmorgan-g
added
the
autosubmit
CaoGiaHieu-dev
added a commit
to CaoGiaHieu-dev/packages
that referenced
this pull request
Nov 5, 2025
* 'main' of https://github.com/CaoGiaHieu-dev/packages: Update packages/go_router/CHANGELOG.md [tool] Remove use of FETCH_HEAD (flutter#10357) Roll Flutter from 027f2e410241 to e5d5c01850f2 (73 revisions) (flutter#10362) [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter#10337) [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter#9242) [pigeon] Replace containsKey with contains in Kotlin generator (flutter#10274) [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter#10245) [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter#10256) [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter#10328) [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter#10348) Roll Flutter from 6f8abdd77820 to 027f2e410241 (26 revisions) (flutter#10335) [google_sign_in] Remove use of OCMock (flutter#10290) [interactive_media_ads] Pin iOS dependency maximum (flutter#10349)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2025
flutter/packages@3d926aa...f13bad3 2025-11-06 [email protected] Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 [email protected] [ci] Add missing deps (flutter/packages#10366) 2025-11-05 [email protected] [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 [email protected] [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 [email protected] [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 [email protected] Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712[email protected] [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 [email protected] [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 [email protected] [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 [email protected] [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 [email protected] [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 [email protected] [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
flutter/packages@3d926aa...f13bad3 2025-11-06 [email protected] Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 [email protected] [ci] Add missing deps (flutter/packages#10366) 2025-11-05 [email protected] [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 [email protected] [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 [email protected] [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 [email protected] Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712[email protected] [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 [email protected] [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 [email protected] [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 [email protected] [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 [email protected] [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 [email protected] [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the doc comments referred to the
allowDrawingOutsideOfViewBoxparameter. However, there is noallowDrawingOutsideOfViewBoxparameter. The parameter is calledallowDrawingOutsideViewBox(without a "Of"). This PR fixes this issue.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3