[go_router] ShellRoute will merge GoRouter's observers #9436

huanghui1998hhh · 2025-06-17T05:03:07Z

ShellRoute currently does not trigger observers defined in GoRouter, which is unexpected behavior.

Fixes flutter/flutter#112196

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

packages/go_router/lib/src/route.dart

…observers through context

justinmc · 2025-07-22T22:21:45Z

@huanghui1998hhh FYI you have some conflicts on this PR.

justinmc · 2025-08-19T22:18:08Z

@huanghui1998hhh Some merge conflicts and a failure still on here FYI.

alexobviously · 2025-08-26T03:59:17Z

Just wondering what the status of this is? We have some issues caused by the bug this PR fixes. Happy to help if there's anything I could do to help this get merged.

Piinks · 2025-09-26T22:16:30Z

Since this is a draft we have not been actively reviewing it, @huanghui1998hhh when you are ready for another review, you can mark the PR 'ready for review'. :)

huanghui1998hhh · 2025-09-30T04:40:29Z

Need more advice on the implementation details. Especially in this case.

This feature is highly requested. We need to properly track page navigation within ShellRoute.

packages/go_router/lib/src/route.dart

packages/go_router/lib/src/misc/merged_observer.dart

2. rename `mergeObservers` to `notifyRootObserver` 3. set `notifyRootObserver`'s default value to `true`

chunhtai · 2025-10-21T16:02:16Z

Can you add a breaking change doc for this?

make a copy of flutter.dev/go/go-router-v16-breaking-changes and update the content
share the doc to everyone with view permission, and add a golink entry in here https://github.com/flutter/website/blob/e86734e470b7b9bd588c7ada19647d4c9f4cdca6/firebase.json#L471
add the link to readme https://github.com/flutter/packages/blob/main/packages/go_router/README.md#migration-guides

packages/go_router/README.md

packages/go_router/lib/src/route.dart

…12584) GoRouter v17 BC document. About flutter/packages#9436

Co-authored-by: chunhtai <[email protected]>

…ShellRoute.notifyRootObserver` instead

chunhtai

LGTM

hannah-hyj

LGTM

…er/packages#9436)

flutter/packages@3d926aa...f13bad3 2025-11-06 [email protected] Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 [email protected] [ci] Add missing deps (flutter/packages#10366) 2025-11-05 [email protected] [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 [email protected] [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 [email protected] [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 [email protected] Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712[email protected] [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 [email protected] [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 [email protected] [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 [email protected] [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 [email protected] [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 [email protected] [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

huanghui1998hhh added 3 commits June 17, 2025 11:39

[go_router] ShellRoute will merge GoRouter's observers

4e87717

fix: test

962c175

update CHANGELOG.md and pubspec.yaml

d954fd5

huanghui1998hhh requested a review from chunhtai as a code owner June 17, 2025 05:03

github-actions bot added the p: go_router label Jun 17, 2025

Merge branch 'main' into main

58f3da2

chunhtai reviewed Jun 17, 2025

View reviewed changes

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

Added observers property to GoRouter to make it easier to access …

1bfdc41

…observers through context

Merge remote-tracking branch 'upstream/main'

7a44752

huanghui1998hhh marked this pull request as draft August 20, 2025 02:21

Merge remote-tracking branch 'upstream/main'

821fef8

huanghui1998hhh marked this pull request as ready for review September 30, 2025 04:27

huanghui1998hhh requested a review from chunhtai September 30, 2025 04:27

chunhtai reviewed Oct 20, 2025

View reviewed changes

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

packages/go_router/lib/src/misc/merged_observer.dart Outdated Show resolved Hide resolved

huanghui1998hhh added 2 commits October 21, 2025 15:27

Merge remote-tracking branch 'upstream/main'

158fe7d

1. hide _MergedNavigatorObserver implementation

1cb0a5f

2. rename `mergeObservers` to `notifyRootObserver` 3. set `notifyRootObserver`'s default value to `true`

huanghui1998hhh requested a review from chunhtai October 21, 2025 08:27

huanghui1998hhh added 2 commits October 21, 2025 16:28

code format

c558677

update package version

f9d6884

huanghui1998hhh and others added 3 commits October 22, 2025 14:47

Merge branch 'main' into main

9a18143

add test for StatefulShellRoute

2b4491c

update README.md

45ba7ea

huanghui1998hhh mentioned this pull request Oct 22, 2025

Add /go/go-router-v17-breaking-changes redirect to firebase.json flutter/website#12584

Merged

chunhtai reviewed Oct 22, 2025

View reviewed changes

packages/go_router/README.md Show resolved Hide resolved

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

parlough pushed a commit to flutter/website that referenced this pull request Oct 22, 2025

Add /go/go-router-v17-breaking-changes redirect to firebase.json (#…

be4f980

…12584) GoRouter v17 BC document. About flutter/packages#9436

huanghui1998hhh and others added 9 commits October 23, 2025 13:35

Update packages/go_router/lib/src/route.dart

f710a94

Co-authored-by: chunhtai <[email protected]>

Update packages/go_router/lib/src/route.dart

5490208

Co-authored-by: chunhtai <[email protected]>

Update packages/go_router/lib/src/route.dart

a313e26

Co-authored-by: chunhtai <[email protected]>

Update comments for ShellRouteBase.notifyRootObserver

01b9c4f

Remove StatefulNavigationShell.notifyRootObserver and use `Stateful…

dc60e90

…ShellRoute.notifyRootObserver` instead

code format

4ae512b

Merge remote-tracking branch 'upstream/main'

a916dc0

Update CHANGELOG.md

b6214c2

update comments for TypedShellRoute, TypedStatefulShellRoute

e661569

huanghui1998hhh requested a review from chunhtai October 24, 2025 02:25

Merge branch 'main' into main

04b510e

chunhtai approved these changes Oct 24, 2025

View reviewed changes

chunhtai requested a review from hannah-hyj October 24, 2025 15:54

hannah-hyj approved these changes Oct 30, 2025

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

auto-submit bot merged commit 8176ffd into flutter:main Nov 5, 2025
80 checks passed

github-actions bot added the triage-framework Should be looked at in framework triage label Nov 5, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

8176ffd [go_router] ShellRoute will merge GoRouter's observers (flutt…

7722081

…er/packages#9436)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 8176ffdbd320 (10 revisions) flutter/flutter#178051

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

8176ffd [go_router] ShellRoute will merge GoRouter's observers (flutt…

7bc4311

…er/packages#9436)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 8176ffdbd320 (10 revisions) flutter/flutter#178063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2025

8176ffd [go_router] ShellRoute will merge GoRouter's observers (flutt…

c03c635

…er/packages#9436)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Packages from 3d926aa495d3 to f13bad3649af (12 revisions) flutter/flutter#178111

Merged

jonmountjoy mentioned this pull request Nov 17, 2025

showCupertinoSheet is missing RouteSettings flutter/flutter#178641

Open

[go_router] ShellRoute will merge GoRouter's observers #9436

[go_router] ShellRoute will merge GoRouter's observers #9436

Uh oh!

Conversation

huanghui1998hhh commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

Uh oh!

Uh oh!

justinmc commented Jul 22, 2025

Uh oh!

justinmc commented Aug 19, 2025

Uh oh!

alexobviously commented Aug 26, 2025

Uh oh!

Piinks commented Sep 26, 2025

Uh oh!

huanghui1998hhh commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

chunhtai commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

huanghui1998hhh commented Jun 17, 2025 •

edited

Loading