Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2023
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit a7a4c1c into flutter:main Aug 28, 2023
@matanlurey matanlurey deleted the engine-platform-embedder-fixtures-docs branch August 28, 2023 20:57
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 28, 2023
…133508)

flutter/engine@91522a1...a7a4c1c

2023-08-28 [email protected] Explain how to update the embedder/fixtures golden outputs. (flutter/engine#45184)
2023-08-28 [email protected] Roll Skia from ded5d08a9999 to 83f6fbad8a38 (1 revision) (flutter/engine#45183)
2023-08-28 [email protected] [Impeller] Simplify color source + text with new Skia API. (flutter/engine#45090)
2023-08-28 [email protected] Re-write docs for DlSkCanvas{Adapter|Dispatcher}. (flutter/engine#44961)
2023-08-28 [email protected] Roll Skia from 5baa2c74fbc6 to ded5d08a9999 (1 revision) (flutter/engine#45181)
2023-08-28 [email protected] Roll Skia from 651ada29fcb0 to 5baa2c74fbc6 (2 revisions) (flutter/engine#45178)
2023-08-28 [email protected] Roll Skia from 477659e6f41b to 651ada29fcb0 (3 revisions) (flutter/engine#45176)
2023-08-28 [email protected] [Impeller] Only enable captures in debug builds. (flutter/engine#45174)
2023-08-28 [email protected] Roll Skia from ce99ad7b587e to 477659e6f41b (1 revision) (flutter/engine#45173)
2023-08-28 [email protected] Skwasm platform views (flutter/engine#43011)
2023-08-28 [email protected] Roll Skia from df783b542165 to ce99ad7b587e (2 revisions) (flutter/engine#45172)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Engine] Not sure how to update goldens in platform/embedder/fixtures

2 participants