This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Skwasm platform views #43011
Merged
Skwasm platform views #43011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he core engine code.
harryterkelsen
approved these changes
Aug 25, 2023
| } | ||
|
|
||
| @override | ||
| PlatformViewStyling createPlatformViewStyling() { |
There was a problem hiding this comment.
imo it would be cleaner to separate out the clip styling into a separate class. I don't think the layers should have this logic in them
|
|
||
| scene.beginRender(); | ||
| final List<LayerSlice> slices = scene.rootLayer.slices; | ||
| final Iterable<Future<DomImageBitmap?>> renderFutures = slices.map( |
There was a problem hiding this comment.
nit: might be cleaner to use whereType to filter out the PlatformViewSlices rather than make a list of nullable futures
There was a problem hiding this comment.
The reason I did it this way is so that I can extract them by index when I'm iterating the slices themselves. If we use whereType there is no simple way to correlate the image bitmap with the slice it was rendered from.
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 28, 2023
…133508) flutter/engine@91522a1...a7a4c1c 2023-08-28 [email protected] Explain how to update the embedder/fixtures golden outputs. (flutter/engine#45184) 2023-08-28 [email protected] Roll Skia from ded5d08a9999 to 83f6fbad8a38 (1 revision) (flutter/engine#45183) 2023-08-28 [email protected] [Impeller] Simplify color source + text with new Skia API. (flutter/engine#45090) 2023-08-28 [email protected] Re-write docs for DlSkCanvas{Adapter|Dispatcher}. (flutter/engine#44961) 2023-08-28 [email protected] Roll Skia from 5baa2c74fbc6 to ded5d08a9999 (1 revision) (flutter/engine#45181) 2023-08-28 [email protected] Roll Skia from 651ada29fcb0 to 5baa2c74fbc6 (2 revisions) (flutter/engine#45178) 2023-08-28 [email protected] Roll Skia from 477659e6f41b to 651ada29fcb0 (3 revisions) (flutter/engine#45176) 2023-08-28 [email protected] [Impeller] Only enable captures in debug builds. (flutter/engine#45174) 2023-08-28 [email protected] Roll Skia from ce99ad7b587e to 477659e6f41b (1 revision) (flutter/engine#45173) 2023-08-28 [email protected] Skwasm platform views (flutter/engine#43011) 2023-08-28 [email protected] Roll Skia from df783b542165 to ce99ad7b587e (2 revisions) (flutter/engine#45172) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Aug 28, 2023
Closed
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
This implements platform views in Skwasm. There are a number of substantial changes rolled up in this change, including: * Reworked the rendering system to use multiple canvases with a single WebGL context, via ImageBitmap rendering. * Reworked our object management and bindings to use the `__externref_t` construct in C code. * Upgraded emscripten to a much newer version * Generified skwasm's scene builder to be able to work with any renderer that can produce `ImageBitmap` objects from Pictures, and whose `Canvas`, `Picture` and `ImageFilter` objects conform to `SceneCanvas`/`ScenePicture`/`SceneImageFilter` For platform views themselves, most stuff is implemented except for clipping. I plan on doing that in a subsequent change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements platform views in Skwasm. There are a number of substantial changes rolled up in this change, including:
__externref_tconstruct in C code.ImageBitmapobjects from Pictures, and whoseCanvas,PictureandImageFilterobjects conform toSceneCanvas/ScenePicture/SceneImageFilterFor platform views themselves, most stuff is implemented except for clipping. I plan on doing that in a subsequent change.