This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] 3.13: [Impeller] Apply color blends on the CPU; fix mask blurs and the Gaussian blur coverage hint. #45130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. (flutter#43519) Apply color filters on the CPU for solid colors and gradients. This fixes flutter/flutter#127232 for the purely color-based color sources. We still need to make the other special color blending paths respect the geometry mask in order to fully resolve the underlying issue: * SaveLayers (if they have an interesting matrix filter -- without a matrix filter, it'll always work today) * TiledTextureContents * TextContents * VerticesContents * AtlasContents (cherry picked from commit 81d5adb)
…er#45079) Resolves flutter/flutter#132936. * In some cases, mask blurs were getting applied twice. * Coverage hint clipping was too aggressive on the second pass of the gaussian blur. * Rework the mask blur applicator to support gracefully falling back to GPU-based color filters when necessary. This fix requires us to cherry-pick: flutter#43519 Going a revert-based route to fix all of these problems would also be pretty complex. https://github.com/flutter/engine/assets/919017/9ee5e856-af7a-42b9-b135-ea268c2ba53f (cherry picked from commit 53595c9)
bdero
changed the title
|
Moving forward with a 3.14 beta cherry-pick for now. Context: flutter/flutter#133360 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.13 cherry-pick for #43519.
This problem is difficult to fix without a series of risky reverts, and so this is a forward fix.
This is a combined cherry-pick of two dependent commits: 81d5adb and 53595c9.