This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix mask blurs and the Gaussian blur coverage hint. #45079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/3.13-blur-fixes
branch
4 times, most recently
from
f0e533d to
3a02a99
Compare
jonahwilliams
approved these changes
Aug 24, 2023
|
|
||
| entity.SetContents( | ||
| paint.WithFilters(std::move(color_text_contents), false)); | ||
| // TODO(bdero): This mask blur application is a hack. It will always wind up |
There was a problem hiding this comment.
Do we have bugs tracking these?
There was a problem hiding this comment.
Whoops, thanks for the reminder. Filed flutter/flutter#133297.
bdero
force-pushed
the
bdero/3.13-blur-fixes
branch
2 times, most recently
from
dd6f749 to
818e0f3
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Where are the dang goldens? |
|
Yeah this isn't working for me either in #45090 |
bdero
force-pushed
the
bdero/3.13-blur-fixes
branch
from
818e0f3 to
367310c
Compare
|
Trying to rebase to see if the goldens will pop out this time. |
|
I went through the goldens manually and things are looking mostly good.
|
|
Yeah we're not handling that case correctly before/after. This patch doesn't introduce a regression. Filed a bug to track it -- I thought I had already fixed this problem: flutter/flutter#133354 |
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Aug 25, 2023
…er#45079) Resolves flutter/flutter#132936. * In some cases, mask blurs were getting applied twice. * Coverage hint clipping was too aggressive on the second pass of the gaussian blur. * Rework the mask blur applicator to support gracefully falling back to GPU-based color filters when necessary. This fix requires us to cherry-pick: flutter#43519 Going a revert-based route to fix all of these problems would also be pretty complex. https://github.com/flutter/engine/assets/919017/9ee5e856-af7a-42b9-b135-ea268c2ba53f (cherry picked from commit 53595c9)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133362) flutter/engine@1ec7b89...53595c9 2023-08-25 [email protected] [Impeller] Fix mask blurs and the Gaussian blur coverage hint. (flutter/engine#45079) 2023-08-25 [email protected] ios: remove shared_application and support app extension build (flutter/engine#44732) 2023-08-25 [email protected] Roll Skia from 76672468e8d7 to 40f4e01fca40 (3 revisions) (flutter/engine#45126) 2023-08-25 [email protected] Roll Fuchsia Mac SDK from 4LHUJjNlDT21v_pdT... to Qj4BGsKtF7EJssKIK... (flutter/engine#45127) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 4LHUJjNlDT21 to Qj4BGsKtF7EJ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
2 tasks
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Aug 28, 2023
…er#45079) Resolves flutter/flutter#132936. * In some cases, mask blurs were getting applied twice. * Coverage hint clipping was too aggressive on the second pass of the gaussian blur. * Rework the mask blur applicator to support gracefully falling back to GPU-based color filters when necessary. This fix requires us to cherry-pick: flutter#43519 Going a revert-based route to fix all of these problems would also be pretty complex. https://github.com/flutter/engine/assets/919017/9ee5e856-af7a-42b9-b135-ea268c2ba53f (cherry picked from commit 53595c9)
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…er#45079) Resolves flutter/flutter#132936. * In some cases, mask blurs were getting applied twice. * Coverage hint clipping was too aggressive on the second pass of the gaussian blur. * Rework the mask blur applicator to support gracefully falling back to GPU-based color filters when necessary. This fix requires us to cherry-pick: flutter#43519 Going a revert-based route to fix all of these problems would also be pretty complex. https://github.com/flutter/engine/assets/919017/9ee5e856-af7a-42b9-b135-ea268c2ba53f
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#132936.
This fix requires us to cherry-pick: #43519
Going a revert-based route to fix all of these problems would also be pretty complex.
I've been testing this against 3.13 and still need to cross reference the other issues. I haven't rigorously tested this against HEAD yet.
Untitled.mov