Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gspencergoog
Copy link
Contributor

Description

Reland #22505, now that flutter/flutter#70637 has landed.

Removes references to dart:ui.Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate.

Related Issues

Tests

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.

@gspencergoog gspencergoog changed the title Remove window Reland: Remove the Window class now that it is no longer used. Nov 17, 2020
@gspencergoog gspencergoog marked this pull request as ready for review November 17, 2020 21:44
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog merged commit 9a5fd32 into flutter:master Nov 18, 2020
@gspencergoog gspencergoog deleted the remove_window branch November 18, 2020 00:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
…er#22566)

Reland flutter#22505, now that flutter/flutter#70637 has landed.

Removes references to dart:ui.Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants