Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Nov 14, 2020

Reverts #22505

That change breaks the docs builds as per: https://ci.chromium.org/p/flutter/builders/try/Linux%20docs/4661?

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 14, 2020
@flar flar requested a review from gspencergoog November 14, 2020 05:45
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 14, 2020
@flar
Copy link
Contributor Author

flar commented Nov 14, 2020

Landing with review pending to unblock the Engine Roller

@flar flar merged commit b0966e8 into master Nov 14, 2020
gspencergoog added a commit to gspencergoog/engine that referenced this pull request Nov 17, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@cbracken cbracken deleted the revert-22505-remove_window branch May 10, 2022 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants