This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Strip bitcode from gen_snapshot #11528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Side note - it might be nice if we could somehow get the compilation to just not generate bitcode for these to begin with, or LTO them. |
Contributor
Author
|
(This change is safe whether there's bitcode or not - the documentation says it's a no-op essentially in that case) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 28, 2019
[email protected]:flutter/engine.git/compare/bf7796611dc1...f93b9cb git log bf77966..f93b9cb --no-merges --oneline 2019-08-27 [email protected] Roll src/third_party/dart 4015a79210..f17d0563fa (5 commits) 2019-08-27 [email protected] Optionally strip bitcode when creating ios framework (flutter/engine#11530) 2019-08-27 [email protected] Bitcode only for release (flutter/engine#11520) 2019-08-27 [email protected] Strip bitcode from gen_snapshot (flutter/engine#11528) 2019-08-27 [email protected] Reuse texture cache in ios_external_texture_gl (flutter/engine#11524) 2019-08-27 [email protected] Roll src/third_party/skia 4b5d65561943..6064ecf7e993 (1 commits) (flutter/engine#11500) 2019-08-27 [email protected] Assert that the JUnit tests are running on Java 8 (flutter/engine#11466) 2019-08-27 [email protected] Roll src/third_party/dart e878bdafe9..4015a79210 (15 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need bitcode in gen_snapshot - it vastly bloats the binary and we're not linking against this/recompiling it from bitcode.