Reuse texture cache in ios_external_texture_gl #11524
Conversation
In current implementation, external texture data flow is a producer-consumer model. When painting external texture, it always asks registered external texture object to produce new CVPixelBuffer, then transforms it to texture. `MarkNewFrameAvailable` function is ignored. This commit changes the dataflow. Now ios_external_texture_gl caches previous opengl texture, if no new frame are available, it do not `copyPixelBuffer` method, just uses cached opengl texture to draw. This is a re-land of #9806, which was previously reverted in #11522.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
1 similar comment
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
[email protected]:flutter/engine.git/compare/bf7796611dc1...f93b9cb git log bf77966..f93b9cb --no-merges --oneline 2019-08-27 [email protected] Roll src/third_party/dart 4015a79210..f17d0563fa (5 commits) 2019-08-27 [email protected] Optionally strip bitcode when creating ios framework (flutter/engine#11530) 2019-08-27 [email protected] Bitcode only for release (flutter/engine#11520) 2019-08-27 [email protected] Strip bitcode from gen_snapshot (flutter/engine#11528) 2019-08-27 [email protected] Reuse texture cache in ios_external_texture_gl (flutter/engine#11524) 2019-08-27 [email protected] Roll src/third_party/skia 4b5d65561943..6064ecf7e993 (1 commits) (flutter/engine#11500) 2019-08-27 [email protected] Assert that the JUnit tests are running on Java 8 (flutter/engine#11466) 2019-08-27 [email protected] Roll src/third_party/dart e878bdafe9..4015a79210 (15 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
4 participants
In current implementation, external texture data flow is a
producer-consumer model. When painting external texture, it always asks
registered external texture object to produce new CVPixelBuffer, then
transforms it to texture.
MarkNewFrameAvailablefunction is ignored.This commit changes the dataflow. Now ios_external_texture_gl caches
previous opengl texture, if no new frame are available, it do not
copyPixelBuffermethod, just uses cached opengl texture to draw.This is a re-land of #9806, which was previously reverted
in #11522.